Use faster StringBuilder instead of StringBuffer - #9
Open
alexmojaki wants to merge 1 commit into
Open
Conversation
From the `StringBuffer` docs: > As of release JDK 5, this class has been supplemented with an equivalent class designed for use by a single thread, StringBuilder. The StringBuilder class should generally be used in preference to this one, as it supports all of the same operations but it is faster, as it performs no synchronization. Unless you want to support really old versions of Java or share buffers between threads (neither of which seem to be the case here), use `StringBuilder`.
|
Do we really want a hash function with an explicit goal of being slow to go faster? :) |
|
Effectiveness of bcrypt should not be tied to how efficiently one
implements it. That's the whole point, so it should always be optimized the
most.
If I could implement bcrypt cracker in assembly or GPU and gain any
advantage it would imply bcrypt algorithm is garbage.
…On Mar 9, 2017 2:17 PM, "Dave Clayton" ***@***.***> wrote:
Do we really want a hash function with an explicit goal of being slow to
go faster? :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABlsxlvxbk8fbptX74iTwSWTTGi3EOtpks5rkF4ygaJpZM4IACdd>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the
StringBufferdocs:Unless you want to support really old versions of Java or share buffers between threads (neither of which seem to be the case here), use
StringBuilder.