[Repository Standards] Align CLAUDE.md and .claude allowlist with real Makefile targets - #805
Open
jentic-harness[bot] wants to merge 3 commits into
Open
jentic-harness[bot] wants to merge 3 commits into
jentic-harness[bot] wants to merge 3 commits into
Conversation
Author
|
[Orchestrator] Scheduled run for job-repo-standards skipped — this PR from the previous run is still open. |
Author
|
[RepoStandardsAgent] CI
Flagging |
jentic-harness
Bot
requested review from
DavidAtJentic,
Manuel-Jentic and
ren-jentic
July 27, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human decisions required
h2>=4.1.0runtime dependency? —h2is declared inpyproject.toml(line 33) but never imported directly anywhere in the codebase. It is HTTP/2 support thatuvicorn[standard]already pulls in transitively, so the explicit pin may be a deliberate security floor (forcing a minimum patched version) rather than dead weight. I did not remove it because that judgement — "is this an intentional transitive-version pin or a redundant line?" — needs a human who knows the security-pin policy. Options: (A) leave it, (B) remove it and rely onuvicorn[standard], (C) keep it but add a comment explaining it's a security floor.UserWarning: Duplicate Operation ID proxybecause the single catch-allproxyroute inbroker/web/routers/execute.py:846serves seven HTTP methods under one function name. Suppressing the warning (e.g. per-methodoperation_ids) would change the committed broker OpenAPI artifact and the generated spec, which is a product-facing API-contract decision, not a janitorial one. Left untouched.react-routerpast the CSRF advisory (unrelated to this PR)? — CI'sSecurity scan(Trivy) fails on a pre-existing HIGH finding,GHSA-qwww-vcr4-c8h2(React Router RSC-mode CSRF bypass), inui/package-lock.jsonatreact-router@7.18.1. This finding is already present onmainand this PR touches no UI/dependency files, so the failure is not introduced here. The fix requires a major 7→8 bump ofreact-router-dom(ui/package.jsonpins^7.18.1), a breaking change well outside a docs/config cleanup — deferred to a human or dependabot. Options: (A) let dependabot handle the major bump, (B) a maintainer bumpsreact-router-domto^8.3.0and adjusts breaking API usage, (C) add a Trivy.trivyignore/VEX entry if the RSC-mode path is not exploitable here.To act on these: add a PR comment that starts with
/ai-implementlistingthe decision numbers you want complete (e.g.
/ai-implement implement 1 and 3 option A).Changes
Commandstable inCLAUDE.mdto match the actual Makefile — the table listed a phantommake fmttarget (the real target isfix), describedcheckas running "unit + arch tests" when it actually runslint score detect-secrets test-arch(no unit tests), and omitted ~17 user-facing targets (openapi,endpoints,dev,start-broker, the sqlite andui-*targets,cli-reference,broker-reference, etc.). Also corrected stale descriptions forinstall,sync,test,start-fixtures, andcov. Verified againstgrep -nE '^[a-z...]+:.*## ' Makefile..claude/settings.json— it allowedBash(make fmt)andBash(make pre-commit), neither of which is a real Makefile target. Corrected tomake fixandmake hooksrespectively, so the allowlist actually matches runnable commands..harness/GARBAGE_COL_STANDARDS.md) so future runs can re-verify command references against the ground-truth Makefile.