feat(ui)!: remove the access-requests surfaces (theme 7, phase 3) - #1377
Open
Manuel-Jentic wants to merge 2 commits into
Open
Manuel-Jentic wants to merge 2 commits into
Manuel-Jentic wants to merge 2 commits into
Conversation
Removes every access-request UI surface for theme 7 phase 3: the dashboard queue page (/app/access-requests now redirects to the dashboard), the nav badges, the ActionInboxBell access-request arm, the rail decision dialogs and inline View/Deny actions, the per-actor ActorAccessRequestsCard, and the accessRequests/provisioningPlan/ provisioningFulfilment libraries with their hooks, query keys, mocks, unit suites, and docker e2e legs. Historical access_request.* stream events are tolerated at ingestion (dropped, never rendered) so old backlogs cannot crash the rail. The shared permission-rule display primitives survive as shared/lib/permissionRules. ui/src/shared/api/generated/** and ui/openapi.json are deliberately untouched: the backend endpoints still exist in this phase and phase 2 owns the regen. BREAKING CHANGE: the access-requests UI is gone; agents obtain access via direct grants and connect sessions (epic #1374). Refs #1374
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of epic #1374 (plan: jentic-one-plans#46). Merges after the phase-2 backend removal; enterprise companion PR removes the admin Requests tab.
Summary
Removes the queue page, rail dialogs (decision/plain/provisioning wizard), pending-count badge/bell arm, per-actor card, and libs/hooks.
/app/access-requestsnow redirects to the dashboard.access_request.*stream events are tolerated-but-unrendered (RETIRED_EVENT_TYPE_PREFIXES, dropped at backlog + SSE ingestion, with pinning tests) so historical rows never crash the rail.Notes
shared/lib/permissionRules.ts— rule primitives survive for the binding-permissions editor.resolveEventkept: Monitor's ack path uses it (discovered coupling).shared/api/generated/**,ui/openapi.json) deliberately untouched — phase 2 owns the spec regen; only hand-written imports removed.provisionAdminOwnedAgent,setAgentOwner) kept.Verification
vitest 1054/1054 (125 files); eslint 0; tsc 0; e2e specs typecheck clean.
Made with Cursor