feat(webhooks): outbound signed webhook notifications (working prototype) - #1098
Open
ritvik-jentic wants to merge 16 commits into
Open
ritvik-jentic wants to merge 16 commits into
ritvik-jentic wants to merge 16 commits into
Conversation
…ype) Emit internal platform events and relay them into a durable delivery queue. Each payload is signed HMAC-SHA256 with Standard Webhooks headers and POSTed to customer-owned endpoints with retry/backoff, dead-lettering, and auto-disable on 410 Gone. Signing secrets are stored per-endpoint with AES-256-GCM encryption and support rotation with a grace period during which the previous secret still verifies. Adds an endpoint management surface: CRUD/rotate/test/deliveries router guarded by webhooks:read / webhooks:write permissions, audit targets, and app-factory lifespan wiring for the delivery worker. The UI ships a webhooks management page with an event-type picker (descriptions + needs-action badge), a delivery log, secret reveal/rotate dialogs, and an in-product relay guide. Tests cover signing (unit) plus integration for delivery, relay, the endpoint service, management HTTP, and secret storage. This is a working prototype (Approach 1: raw signed webhook + relay) — functional end to end but not yet fully polished or hardened. Co-authored-by: Cursor <cursoragent@cursor.com>
…ention, per-endpoint concurrency
…icated egress policy, metrics
…ed_cidrs, duration_ms)
…p, per-attempt metrics, payload enrichment
…talog, enriched events
…R editor, expressive delivery errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements Approach 1: outbound signed webhooks + relay model.
410 Gone.What's included
shared/webhooks/*,admin/services/webhooks/*).a1b2c3d4e5f7_add_webhook_tables).webhooks:read/webhooks:write, plus audit targets and app-factory lifespan wiring.Test plan
make lint(ruff + mypy) passesuv run detect-secretsshows no new findingsMade with Cursor