Skip to content

Support Spanish and Simplified Chinese - #7

Merged
hexlianine merged 6 commits into
jenkinsci:masterfrom
hexlianine:i18n
Mar 10, 2026
Merged

hexlianine merged 6 commits into
jenkinsci:masterfrom
hexlianine:i18n

Conversation

@hexlianine

Copy link
Copy Markdown
Contributor

This PR adds internationalization (i18n) support for Java display names and completes translations for Spanish and Simplified Chinese. It also includes UI improvements and code cleanup.

resolves #3

Testing done

Manually tested the following scenarios:

  • Verified MFA configuration page displays correctly in English, Spanish, and Chinese
  • Verified MFA login page displays correctly in all three languages
  • Verified MFA management link page displays correctly in all three languages
  • Verified MFA user property configuration displays correctly in all three languages
  • Confirmed existing MFA functionality remains unchanged after refactoring

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Summary of changes:

  • feat: Added i18n support for Java display names via Messages.properties files
  • feat: Completed Spanish translation and added Simplified Chinese translation
  • feat: Cleaned up escape sequences and improved UI styling
  • chore: Corrected language name references
  • refactor: Removed unused UIConstants class

hexlianine and others added 6 commits March 8, 2026 23:12
- Complete missing keys in Spanish translations (MFALoginAction, MFAUserProperty)
- Add Simplified Chinese translations for all UI components
- Support locale files for MFAGlobalConfiguration, MFALoginAction, MFAManagementLink, MFASetupAction, and MFAUserProperty

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add Messages.properties with English, Spanish, and Chinese translations
- Localize DisplayNames constants (CONFIGURE_MFA, MFA_LOGIN, MFA_SECURITY_REALM,
  MFA_USER_MANAGEMENT, MULTI_FACTOR_AUTHENTICATION, OPENMFA_GLOBAL_CONFIGURATION)
- Localize MFAManagementLink description
- Update Java classes to use generated Messages class for localization
- JS files already use localized strings from DOM data attributes

Fixes jenkinsci#3

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@hexlianine
hexlianine requested a review from a team as a code owner March 10, 2026 15:14
@hexlianine hexlianine added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Mar 10, 2026
@hexlianine hexlianine self-assigned this Mar 10, 2026
@hexlianine
hexlianine merged commit 34d9e94 into jenkinsci:master Mar 10, 2026
20 checks passed
@hexlianine
hexlianine deleted the i18n branch March 10, 2026 15:27
@hexlianine hexlianine changed the title I18n Support Spanish and Simplified Chinese Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete Spanish translation and add Chinese language support

1 participant