Repository navigation
Conversation
The Leaderboards tab and the public board get a search field, like the Players tab's: typing pauses for 300 ms, then the board reloads from page one with `q` in the query (and the URL, so a search can be linked). A search narrows the rows and never their ranks. Every row is ranked on the whole board first (ROW_NUMBER over the same order the board already used), then the search filters, then the page is sliced, so a player in 37th place is found as warcon-app#37, not #1. The total and the pager count the matches. What matches depends on who is looking, as with the rest of the board: - the panel matches any name a player used on these servers, anywhere in it, and digits also match the start of a SteamID (the Players tab's rule); - a public board matches only the name it shows, the last one, so a search there cannot tie a SteamID or an old name to a player. `%` and `_` are escaped, as in seen.ts. The export follows the search too, since it writes "the board as it is set". With no search the query is the one it was, and ranks come out the same. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011wkaN3kHsCQGhxCxeAqERQ
Owner
Author
|
CI passed (853 pass, 0 fail); the real PR is upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened only so the database suites run in this fork's Actions before the upstream PR. Will be closed.