Skip to content

fix yuv and luv color conversions #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasmcaus merged 2 commits into from
Sep 23, 2026
Merged

fix yuv and luv color conversions #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
622e8d2
fix yuv and luv color conversions
omadson Sep 22, 2026
0706bf6
rename img to tens in yuv/luv color conversions
omadson Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions caer/color/_luv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ def luv2bgr(tens: Tensor) -> Tensor:
"This function converts an LUV Tensor to its BGR counterpart"
)

img = cv.cvtColor(tens, LUV2BGR)
return to_tensor(img, cspace="bgr")
tens = cv.cvtColor(tens, LUV2BGR)
return to_tensor(tens, cspace="bgr")


def luv2rgb(tens: Tensor) -> Tensor:
Expand All @@ -74,8 +74,8 @@ def luv2rgb(tens: Tensor) -> Tensor:
"This function converts a LUV Tensor to its RGB counterpart"
)

img = cv.cvtColor(tens, LUV2RGB)
return to_tensor(img, cspace="rgb")
tens = cv.cvtColor(tens, LUV2RGB)
return to_tensor(tens, cspace="rgb")


def luv2gray(tens: Tensor) -> Tensor:
Expand All @@ -98,9 +98,9 @@ def luv2gray(tens: Tensor) -> Tensor:
"This function converts an LUV Tensor to its GRAY counterpart"
)

img = luv2bgr(tens)
img = bgr2gray(tens)
return to_tensor(img, cspace="gray")
tens = luv2bgr(tens)
tens = bgr2gray(tens)
return to_tensor(tens, cspace="gray")


def luv2hls(tens: Tensor) -> Tensor:
Expand All @@ -123,9 +123,9 @@ def luv2hls(tens: Tensor) -> Tensor:
"This function converts an LUV Tensor to its HLS counterpart"
)

img = luv2bgr(tens)
img = bgr2hls(tens)
return to_tensor(img, cspace="hls")
tens = luv2bgr(tens)
tens = bgr2hls(tens)
return to_tensor(tens, cspace="hls")


def luv2hsv(tens: Tensor) -> Tensor:
Expand All @@ -148,9 +148,9 @@ def luv2hsv(tens: Tensor) -> Tensor:
"This function converts an LUV Tensor to its HSV counterpart"
)

img = luv2bgr(tens)
img = bgr2hsv(tens)
return to_tensor(img, cspace="hsv")
tens = luv2bgr(tens)
tens = bgr2hsv(tens)
return to_tensor(tens, cspace="hsv")


def luv2lab(tens: Tensor) -> Tensor:
Expand All @@ -173,9 +173,9 @@ def luv2lab(tens: Tensor) -> Tensor:
"This function converts an LUV Tensor to its LAB counterpart"
)

img = luv2bgr(tens)
img = bgr2lab(tens)
return to_tensor(img, cspace="lab")
tens = luv2bgr(tens)
tens = bgr2lab(tens)
return to_tensor(tens, cspace="lab")


def luv2yuv(tens: Tensor) -> Tensor:
Expand All @@ -198,6 +198,6 @@ def luv2yuv(tens: Tensor) -> Tensor:
"This function converts an LUV Tensor to its YUV counterpart"
)

img = luv2bgr(tens)
img = bgr2yuv(tens)
return to_tensor(img, cspace="yuv")
tens = luv2bgr(tens)
tens = bgr2yuv(tens)
return to_tensor(tens, cspace="yuv")
38 changes: 19 additions & 19 deletions caer/color/_yuv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ def yuv2bgr(tens: Tensor) -> Tensor:
"This function converts an YUV Tensor to its BGR counterpart"
)

img = cv.cvtColor(tens, YUV2BGR)
return to_tensor(img, cspace="bgr")
tens = cv.cvtColor(tens, YUV2BGR)
return to_tensor(tens, cspace="bgr")


def yuv2rgb(tens: Tensor) -> Tensor:
Expand All @@ -74,8 +74,8 @@ def yuv2rgb(tens: Tensor) -> Tensor:
"This function converts a YUV Tensor to its RGB counterpart"
)

img = cv.cvtColor(tens, YUV2RGB)
return to_tensor(img, cspace="rgb")
tens = cv.cvtColor(tens, YUV2RGB)
return to_tensor(tens, cspace="rgb")


def yuv2gray(tens: Tensor) -> Tensor:
Expand All @@ -98,9 +98,9 @@ def yuv2gray(tens: Tensor) -> Tensor:
"This function converts an YUV Tensor to its GRAY counterpart"
)

img = yuv2bgr(tens)
img = bgr2gray(tens)
return to_tensor(img, cspace="gray")
tens = yuv2bgr(tens)
tens = bgr2gray(tens)
return to_tensor(tens, cspace="gray")


def yuv2hls(tens: Tensor) -> Tensor:
Expand All @@ -123,9 +123,9 @@ def yuv2hls(tens: Tensor) -> Tensor:
"This function converts an YUV Tensor to its HLS counterpart"
)

img = yuv2bgr(tens)
img = bgr2hls(tens)
return to_tensor(img, cspace="hls")
tens = yuv2bgr(tens)
tens = bgr2hls(tens)
return to_tensor(tens, cspace="hls")


def yuv2hsv(tens: Tensor) -> Tensor:
Expand All @@ -148,9 +148,9 @@ def yuv2hsv(tens: Tensor) -> Tensor:
"This function converts an YUV Tensor to its HSV counterpart"
)

img = yuv2bgr(tens)
img = bgr2hsv(tens)
return to_tensor(img, cspace="hsv")
tens = yuv2bgr(tens)
tens = bgr2hsv(tens)
return to_tensor(tens, cspace="hsv")


def yuv2lab(tens: Tensor) -> Tensor:
Expand All @@ -173,9 +173,9 @@ def yuv2lab(tens: Tensor) -> Tensor:
"This function converts an YUV Tensor to its LAB counterpart"
)

img = yuv2bgr(tens)
img = bgr2lab(tens)
return to_tensor(img, cspace="lab")
tens = yuv2bgr(tens)
tens = bgr2lab(tens)
return to_tensor(tens, cspace="lab")


def yuv2luv(tens: Tensor) -> Tensor:
Expand All @@ -198,6 +198,6 @@ def yuv2luv(tens: Tensor) -> Tensor:
"This function converts an YUV Tensor to its LUV counterpart"
)

img = yuv2bgr(tens)
img = bgr2luv(tens)
return to_tensor(img, cspace="luv")
tens = yuv2bgr(tens)
tens = bgr2luv(tens)
return to_tensor(tens, cspace="luv")
6 changes: 6 additions & 0 deletions tests/color/test_luv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import caer
import cv2 as cv
import os
import numpy as np

here = os.path.dirname(os.path.dirname(__file__))
tens_path = os.path.join(here, 'data', 'green_fish.jpg')
Expand Down Expand Up @@ -50,6 +51,7 @@ def test_luv2gray():
assert len(gray.shape) == 2 or (len(gray.shape) == 3 and gray.shape[-1] == 1)
assert isinstance(gray, caer.Tensor)
assert gray.is_gray()
assert np.all(gray == cv.cvtColor(cv.cvtColor(cv_luv, cv.COLOR_LUV2BGR), cv.COLOR_BGR2GRAY))


def test_luv2hsv():
Expand All @@ -61,6 +63,7 @@ def test_luv2hsv():
assert len(hsv.shape) == 3
assert isinstance(hsv, caer.Tensor)
assert hsv.is_hsv()
assert np.all(hsv == cv.cvtColor(cv.cvtColor(cv_luv, cv.COLOR_LUV2BGR), cv.COLOR_BGR2HSV))


def test_luv2hls():
Expand All @@ -72,6 +75,7 @@ def test_luv2hls():
assert len(hls.shape) == 3
assert isinstance(hls, caer.Tensor)
assert hls.is_hls()
assert np.all(hls == cv.cvtColor(cv.cvtColor(cv_luv, cv.COLOR_LUV2BGR), cv.COLOR_BGR2HLS))


def test_luv2lab():
Expand All @@ -83,6 +87,7 @@ def test_luv2lab():
assert len(lab.shape) == 3
assert isinstance(lab, caer.Tensor)
assert lab.is_lab()
assert np.all(lab == cv.cvtColor(cv.cvtColor(cv_luv, cv.COLOR_LUV2BGR), cv.COLOR_BGR2LAB))


def test_luv2yuv():
Expand All @@ -94,3 +99,4 @@ def test_luv2yuv():
assert len(yuv.shape) == 3
assert isinstance(yuv, caer.Tensor)
assert yuv.is_yuv()
assert np.all(yuv == cv.cvtColor(cv.cvtColor(cv_luv, cv.COLOR_LUV2BGR), cv.COLOR_BGR2YUV))
6 changes: 6 additions & 0 deletions tests/color/test_yuv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import caer
import cv2 as cv
import os
import numpy as np

here = os.path.dirname(os.path.dirname(__file__))
tens_path = os.path.join(here, 'data', 'green_fish.jpg')
Expand Down Expand Up @@ -50,6 +51,7 @@ def test_yuv2gray():
assert len(gray.shape) == 2 or (len(gray.shape) == 3 and gray.shape[-1] == 1)
assert isinstance(gray, caer.Tensor)
assert gray.is_gray()
assert np.all(gray == cv.cvtColor(cv.cvtColor(cv_yuv, cv.COLOR_YUV2BGR), cv.COLOR_BGR2GRAY))


def test_yuv2hsv():
Expand All @@ -61,6 +63,7 @@ def test_yuv2hsv():
assert len(hsv.shape) == 3
assert isinstance(hsv, caer.Tensor)
assert hsv.is_hsv()
assert np.all(hsv == cv.cvtColor(cv.cvtColor(cv_yuv, cv.COLOR_YUV2BGR), cv.COLOR_BGR2HSV))


def test_yuv2hls():
Expand All @@ -72,6 +75,7 @@ def test_yuv2hls():
assert len(hls.shape) == 3
assert isinstance(hls, caer.Tensor)
assert hls.is_hls()
assert np.all(hls == cv.cvtColor(cv.cvtColor(cv_yuv, cv.COLOR_YUV2BGR), cv.COLOR_BGR2HLS))


def test_yuv2lab():
Expand All @@ -83,6 +87,7 @@ def test_yuv2lab():
assert len(lab.shape) == 3
assert isinstance(lab, caer.Tensor)
assert lab.is_lab()
assert np.all(lab == cv.cvtColor(cv.cvtColor(cv_yuv, cv.COLOR_YUV2BGR), cv.COLOR_BGR2LAB))


def test_yuv2luv():
Expand All @@ -94,3 +99,4 @@ def test_yuv2luv():
assert len(luv.shape) == 3
assert isinstance(luv, caer.Tensor)
assert luv.is_luv()
assert np.all(luv == cv.cvtColor(cv.cvtColor(cv_yuv, cv.COLOR_YUV2BGR), cv.COLOR_BGR2LUV))
Loading