Repository navigation
Pin System.Security.Cryptography.Pkcs to 10.0.13 (GHSA-2fmv-rv2c-59x7) - #156
Merged
Merged
Conversation
NuGet.Packaging 7.0.3, pulled in transitively by the analyzer testing packages, depends on the vulnerable Pkcs 9.0.6, failing restore with NU1902.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 65.63% 65.62% -0.01%
==========================================
Files 337 337
Lines 30420 30420
Branches 5710 5710
==========================================
- Hits 19966 19964 -2
Misses 9035 9035
- Partials 1419 1421 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NuGet.Packaging 7.0.3, pulled in transitively by Microsoft.CodeAnalysis.*.Testing 1.1.4, depends on System.Security.Cryptography.Pkcs 9.0.6, which has a known moderate vulnerability (GHSA-2fmv-rv2c-59x7). This fails restore of SharpDicom.Analyzers.Tests with NU1902 (warnings as errors).
Pins Pkcs to 10.0.13 in Directory.Packages.props and references it directly from the analyzer test project, matching the existing SQLite/SharpCompress pin pattern.
dotnet list package --vulnerable --include-transitivereports nothingSummary by cubic
Pins System.Security.Cryptography.Pkcs to 10.0.13 so restore of the analyzer test project no longer fails with NU1902 warnings-as-errors.
The vulnerable 9.0.6 version comes in transitively from NuGet.Packaging via the Microsoft.CodeAnalysis.*.Testing packages (GHSA-2fmv-rv2c-59x7).
Directory.Packages.propsand references it directly from the test project, matching the existing SQLite/SharpCompress pin pattern.dotnet list package --vulnerable --include-transitivereports nothing, and all 22 analyzer tests pass.Written for commit 3ab1072. Summary will update on new commits.