Repository navigation
Allow 0.1% codecov project coverage threshold - #152
Merged
Merged
Conversation
Project coverage fluctuates by up to 0.05% between runs with no source changes, failing codecov/project on about half of recent main commits.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 65.61% 65.64% +0.02%
==========================================
Files 337 337
Lines 30420 30420
Branches 5710 5710
==========================================
+ Hits 19961 19969 +8
+ Misses 9038 9032 -6
+ Partials 1421 1419 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codecov/projectuses a zero threshold, so any drop fails it. Coverage fluctuates between runs even when no source changes: across the last 12 dependency-only commits on main it moved between -0.05% and +0.03%, and the check failed on 6 of them. #150 hit the same thing (-0.01%, fromStorageCommitmentRequest.csandDwt97.cs, neither touched by the PR).Adds
.github/codecov.ymlallowing a 0.1% project drop, which still catches real regressions. The patch check is unchanged.The underlying run-to-run variation (hits dropping in deterministic tests such as
StorageCommitmentTests) is not addressed here.Summary by cubic
Adds a 0.1% coverage threshold for codecov's project check so small run-to-run variations no longer fail it.
Coverage fluctuates up to ±0.05% between identical runs, failing the check on about half of recent
maincommits even with no source changes. The new threshold still catches real regressions, and the patch check is unchanged.Written for commit 1aec711. Summary will update on new commits.