Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Use git submodule for grabberconfig - #493

Merged
jangernert merged 3 commits into
masterfrom
grabberconfig
May 25, 2017
Merged

Use git submodule for grabberconfig#493
jangernert merged 3 commits into
masterfrom
grabberconfig

Conversation

@bilelmoussaoui

@bilelmoussaoui bilelmoussaoui commented May 25, 2017

Copy link
Copy Markdown
Contributor

Instead of copying the updates done by the guys at five-filters, it's better to use a git submodule
@jscurtu is there any modification that should be done on the flatpak package?

@jangernert

Copy link
Copy Markdown
Owner

Is it possible to apply patches to the submodule?
We still carry a patched config for phoronix to remove double <div class='content'>

@bilelmoussaoui

Copy link
Copy Markdown
Contributor Author

The patches should be applied to five-filters repository instead. Only if we wish to keep maintaining that huge database by ourselves...

@jangernert

Copy link
Copy Markdown
Owner

The changes were removed from filefilters. So I don't think it's something they'll merge.
Alternatively we have to rename the content-class in article.html and style.css to feedreader_content or something

@bilelmoussaoui

Copy link
Copy Markdown
Contributor Author

Yeah, i will make sure of that before we merge #479

@bilelmoussaoui

Copy link
Copy Markdown
Contributor Author

We can add a prefix for each class/id like FeedReaderArticleView to be sure that we won't mess with any other content

@jangernert
jangernert merged commit ef74b69 into master May 25, 2017
@bilelmoussaoui
bilelmoussaoui deleted the grabberconfig branch May 25, 2017 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants