This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Use git submodule for grabberconfig - #493
Merged
Merged
Conversation
Owner
|
Is it possible to apply patches to the submodule? |
Contributor
Author
|
The patches should be applied to five-filters repository instead. Only if we wish to keep maintaining that huge database by ourselves... |
Owner
|
The changes were removed from filefilters. So I don't think it's something they'll merge. |
Contributor
Author
|
Yeah, i will make sure of that before we merge #479 |
Contributor
Author
|
We can add a prefix for each class/id like FeedReaderArticleView to be sure that we won't mess with any other content |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of copying the updates done by the guys at five-filters, it's better to use a git submodule
@jscurtu is there any modification that should be done on the flatpak package?