fix(core): ensure renderer refresh when only hideLabelsOnMove is enabled - #1545
Open
wwfra wants to merge 1 commit into
Open
fix(core): ensure renderer refresh when only hideLabelsOnMove is enabled#1545wwfra wants to merge 1 commit into
wwfra wants to merge 1 commit into
Conversation
Fix a logic omission in mouseup handler where the graph failed to refresh after dragging if only `hideLabelsOnMove` was set to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a logic omission in mouseup handler where the graph failed to refresh after dragging if only
hideLabelsOnMovewas set to true.Pull request type
Check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
When the renderer is configured with
hideLabelsOnMove: truebuthideEdgesOnMove: false, the graph fails to refresh upon releasing the mouse after a camera pan or drag action.As a result, the graph remains in its simplified "moving" state where labels stay hidden even after the movement has completely stopped. This happens because the
mouseup(or drag end) handler previously only checkedthis.renderer.getSetting("hideEdgesOnMove")before triggeringthis.renderer.refresh().What is the new behavior?
The conditional check in the delayed
mouseuphandler has been updated to includethis.renderer.getSetting("hideLabelsOnMove").Now, if either
hideEdgesOnMoveorhideLabelsOnMoveis enabled,this.renderer.refresh()will be correctly invoked when the user stops moving the camera, ensuring that both edges and labels restore their proper visibility states smoothly.Other information
Bug:

Fixed:
