Skip to content

fix(core): ensure renderer refresh when only hideLabelsOnMove is enabled - #1545

Open
wwfra wants to merge 1 commit into
jacomyal:mainfrom
wwfra:fix-hideLabelsOnMove-cannot-refresh
Open

fix(core): ensure renderer refresh when only hideLabelsOnMove is enabled#1545
wwfra wants to merge 1 commit into
jacomyal:mainfrom
wwfra:fix-hideLabelsOnMove-cannot-refresh

Conversation

@wwfra

@wwfra wwfra commented Jun 24, 2026

Copy link
Copy Markdown

Fix a logic omission in mouseup handler where the graph failed to refresh after dragging if only hideLabelsOnMove was set to true.

Pull request type

Check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

NOTE: Before to create a PR, read our contributing guide

NOTE: Try to limit your pull request to one type, submit multiple pull requests if needed.

What is the current behavior?

Issue Number: N/A

When the renderer is configured with hideLabelsOnMove: true but hideEdgesOnMove: false, the graph fails to refresh upon releasing the mouse after a camera pan or drag action.

As a result, the graph remains in its simplified "moving" state where labels stay hidden even after the movement has completely stopped. This happens because the mouseup (or drag end) handler previously only checked this.renderer.getSetting("hideEdgesOnMove") before triggering this.renderer.refresh().

What is the new behavior?

The conditional check in the delayed mouseup handler has been updated to include this.renderer.getSetting("hideLabelsOnMove").

Now, if either hideEdgesOnMove or hideLabelsOnMove is enabled, this.renderer.refresh() will be correctly invoked when the user stops moving the camera, ensuring that both edges and labels restore their proper visibility states smoothly.

Other information

Bug:
Bug

Fixed:
Fixed

Fix a logic omission in mouseup handler where the graph failed to refresh after dragging if only `hideLabelsOnMove` was set to true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant