Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new test cleanup should use force: true to avoid afterEach failures if a temp directory is already missing, preventing flaky test behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR makes asset deletion during incremental rebuilds idempotent by switching from fs.promises.unlink to fs.promises.rm(..., { force: true }), preventing ENOENT from aborting rebuilds when a delete event is replayed.
Changes:
- Replace
fs.promises.unlinkwithfs.promises.rm(..., { force: true })for deleted generated assets. - Add a regression test to ensure deleting the same asset twice does not fail.
File summaries
| File | Description |
|---|---|
| quartz/plugins/emitters/assets.ts | Makes delete handling resilient to missing files by using rm(..., { force: true }). |
| quartz/plugins/emitters/assets.test.ts | Adds a regression test covering repeated delete events for the same asset. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const tempDirs: string[] = [] | ||
|
|
||
| afterEach(async () => { | ||
| await Promise.all(tempDirs.splice(0).map((dir) => fs.promises.rm(dir, { recursive: true }))) |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unlinkwithrm(..., { force: true })for deleted assetsReproduction
When a delete event is replayed after its generated asset has already been removed, the asset emitter throws
ENOENTand aborts the incremental rebuild.Testing
npm run checknpm test(164 tests passed)This PR was written entirely using an LLM.