Skip to content

ci: RTL testbenches and zero-multiplier check in CI (M4 Task 7 step 2) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackthepunished merged 1 commit into from
Aug 8, 2026
Merged

ci: RTL testbenches and zero-multiplier check in CI (M4 Task 7 step 2) #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with: { python-version: "3.11" }
- run: sudo apt-get update && sudo apt-get install -y --no-install-recommends verilator yosys
- run: python -m venv .venv && .venv/bin/pip install -e ".[dev]" --quiet
- run: .venv/bin/pip install torch --index-url https://download.pytorch.org/whl/cpu --quiet
- run: make test
- run: make lint rtl_test
- run: make synth_check

@coderabbitai coderabbitai Bot Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Make synth_check propagate Yosys failures.

Line 15 relies on Makefile:synth_check, which runs Yosys through tee without enabling pipefail. In shells without pipefail, the pipeline status is the last command’s status, so a successful tee can hide a failed Yosys process. (pubs.opengroup.org)

Update synth_check to use a shell with pipefail, or avoid the pipeline, before relying on this step as a synthesis gate.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 15, Update the Makefile:synth_check recipe
invoked by the CI run to ensure Yosys failures propagate through its tee
pipeline, either by enabling pipefail for the recipe shell or by removing the
pipeline; keep synth_check failing whenever Yosys fails.

Loading