fix small display bugs: stale time highlight; ovelap brackets - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes several small display bugs:
Fixes
We now keep a record of the currently highlighted utterances. This record is then checked when the play-head moves. Previously it was done too implicitly.
Ugh, it's complicated. It boiled down to:
a. measuring text coordinates properly. We can't look at bracket position, we must look at the overlap text position
b. because we add margins while aligning overlaps, we can introduce new line breaks. Therefore, there is a sequential dependency on how we construct overlaps. We can't compute overlaps in isolation, we have to loop over the document in order so that each overlap takes into account how prior overlaps mutate the text positions...