Use AWS SDK version 3 - #19
Open
Jimilian wants to merge 1 commit into
Open
Conversation
According to [1] "version 3 interfaces are backwards compatible with version 2". Update is needed to avoid problems with using two different major versions of AWS SDK inside one td-agent daemon. [1] https://docs.aws.amazon.com/sdk-for-ruby/v3/api/index.html
|
Seems like a duplicate of #17 |
Author
|
@johanneswuerbach yes, true - target is the same. Unfortunately, I saw your PR too late, otherwise I would push my change to your PR, because if I understood correctly in your PR you modified autogenerated file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to [1] "version 3 interfaces are backwards compatible with
version 2". Update is needed to avoid problems with using two different
major versions of AWS SDK inside one td-agent daemon.
[1] https://docs.aws.amazon.com/sdk-for-ruby/v3/api/index.html]
p.s. We used the version of plugin based built from this PR for 1 months in production - no regression found.