fix #34

[vyacheslavhere]

Summary by CodeRabbit

• Bug Fixes
  • Improved type validation accuracy by refining union type matching logic to prevent incorrect type acceptance in edge cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c9efff0-a690-4688-bac6-ffa4bb991091

📥 Commits

Reviewing files that changed from the base of the PR and between aa9799f and a11039f.

📒 Files selected for processing (1)

• src/main/kotlin/com/kingmang/ixion/typechecker/TypeResolver.kt

💤 Files with no reviewable changes (1)

• src/main/kotlin/com/kingmang/ixion/typechecker/TypeResolver.kt

---

📝 Walkthrough

Walkthrough

A single line is removed from the union-handling logic in TypeResolver.typesMatch, eliminating a symmetric check that previously returned true when arg was a UnionType containing par. The remaining conditions handle mutual containment or par being a UnionType containing arg.

Changes

Cohort / File(s)	Summary
Union Type Matching Logic src/main/kotlin/com/kingmang/ixion/typechecker/TypeResolver.kt	Removed the symmetric condition from union type matching that allowed arg to be a UnionType containing par. The asymmetric approach now only succeeds when both are UnionType with mutual containment or when par is a UnionType directly containing arg.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Through union types we'd hop both ways, you see,
But one direction caused some complexity,
A symmetric check became too much to bear,
So off we snipped it with a rabbit's care,
Now TypeResolver's logic soars up high,
With cleaner types beneath the code-y sky! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix #34' is vague and does not convey meaningful information about the specific change being made.	Consider updating the title to describe the actual fix, such as 'Tighten UnionType handling in TypeResolver.typesMatch' or similar, to make the change clear without referring to the PR number.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}