Remover atributos de request do método APIResource::createAPI - #33
Open
erickmcarvalho wants to merge 1 commit into
Open
Remover atributos de request do método APIResource::createAPI#33erickmcarvalho wants to merge 1 commit into
erickmcarvalho wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sugiro a remoção dos atibutos da requisição no método
APIResource::createAPI, pois os atributos causam override na resposta da API, o que pode levar em perda de dados da resposta.Exemplo:
Atributo da lista de itens na requisição:
[ 'description' => 'Produto Teste', 'price_cents' => 100, 'quantity' => 1 ]Como a resposta vem da API:
[ 'id' => '11DA8B1662EC4C30BC4C78AEDC619145', 'description' => 'Produto Teste', 'price_cents' => 100, 'quantity' => 1, 'created_at' => '2014-06-17T09:58:05-03:00', 'updated_at' => '2014-06-17T09:58:05-03:00', 'price' => 'R$ 10,00' ]Porém, ao aplicar o código
Basicamente causa override pelas chaves de request e response serem as mesmas, e com isso você perde dados da resposta.
Não há necessidade alguma de incluir os atributos de request na resposta.