Skip to content

fix: remote ~/ path expansion and SSH Match garbage aliases - #5

Merged
itsjeremyjohnson merged 4 commits into
mainfrom
fix/remote-tilde-path-and-match-parse
Aug 27, 2026
Merged

itsjeremyjohnson merged 4 commits into
mainfrom
fix/remote-tilde-path-and-match-parse

Conversation

@itsjeremyjohnson

Copy link
Copy Markdown
Owner

Summary

  • Fixes live wpgo failures on default ~/public_html sites by preserving remote tilde expansion.
  • Removes adapter double-wrap of already-built cd+wp commands.
  • Stops SSH Match exec lines from polluting the site registry with junk aliases.

Test plan

  • go test ./internal/adapter/ ./internal/registry/ ./internal/wpcli/
  • Live core version on omahadentists, chadbierbaum, emotionc, pathwayredlands
  • sites list has no Match-exec garbage aliases

wpgo was failing on default ~/public_html sites because Build
single-quoted the path (blocking remote tilde expansion) and the
adapter double-wrapped already-built cd+wp commands.

- Escape remote paths as "$HOME"/'…' in wpcli.Build
- Run pre-built commands as-is in standard/wpengine adapters
- Strip SSH Match blocks and reject Match-exec junk aliases
@itsjeremyjohnson

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 832635bfbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/registry/sshconfig.go Outdated
Comment thread internal/registry/sshconfig.go Outdated
Co-Authored-By: Claude <noreply@anthropic.com>
@itsjeremyjohnson

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56ea14db6a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/registry/sshconfig.go Outdated
Co-Authored-By: Claude <noreply@anthropic.com>
@itsjeremyjohnson

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 9f2ed7f9cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjeremyjohnson

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f2ed7f9cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/registry/sshconfig.go Outdated
Co-Authored-By: Claude <noreply@anthropic.com>
@itsjeremyjohnson

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: a1f3b65bb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjeremyjohnson
itsjeremyjohnson merged commit 3871a19 into main Aug 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant