fix: make manifest_version change backward compatible

[khalsz]

This PR help make manifest_version change backward compatible with the older name - version

[jholloc]

@olivhoenen could someone on your side take a look at this please. It is a blocking issue for adoption of latest version here as the current version is incompatible with all the existing manifest files we have.

[olivhoenen]

Hi, sorry for the late answer on this one.
I believe this can't work properly if based on develop branch (please note that @Yannicked is currently working on manifest validation with Pydantic in PR #90).

If you want this rapidly we can target patch release on top of 0.15, but you should confirm first that it does what you expect.
I may have wrongly set up my case but I could not have the relevant warnings / message when ingesting an old manifest with version=1 after applying your patch on top of main.

[fcasson]

Supporting both names "version" and "manifest_version" is the easy part.

The harder part is: If a version 1 manifest is provided, it actually needs to be ingestable: Not the case with the current PR

[olivhoenen]

Supporting both names "version" and "manifest_version" is the easy part.

The harder part is: If a version 1 manifest is provided, it actually needs to be ingestable: Not the case with the current PR

Indeed. Note that this PR shall be closed, as @jholloc had a replacement at #96 (using main as base branch instead of develop). It was merged an a hotfix release 0.15.2 was published. If this one still has problems please make a new issue to describes them and how they can be reproduced.