Tighten table and attachment annotation ref checks in tests - #573
Open
FedyaBadyilo wants to merge 1 commit into
Open
Tighten table and attachment annotation ref checks in tests#573FedyaBadyilo wants to merge 1 commit into
FedyaBadyilo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_test_table_refshelper: reject dangling table/attach annotations always; require every table to be linked on placement formats (docx, pptx, pdf); optionally compare uid multisets so a lost ref is visible when two DOCX tables share a content-hash uid.This is tests only. It does not change the public contract and does not claim that every format must have a 1:1 annotation↔object map (HTML / Excel / CSV / email / uncited GROBID figures stay out).
Test plan
python -m unittest tests.unit_tests.test_misc_object_refs -v:1231:test_docx,test_pptx,test_structure_and_annotations,test_pdf_with_some_tables(scan + text layer),tests.api_tests.test_api_misc_with_images_refs(article needs Grobid; without it the request 500s in
ArticleStructureExtractor, unrelated to this change)flake8on the touched test files