Fix TableAnnotation position when a PDF table is linked to the line a… - #568
Open
FedyaBadyilo wants to merge 1 commit into
Open
Fix TableAnnotation position when a PDF table is linked to the line a…#568FedyaBadyilo wants to merge 1 commit into
FedyaBadyilo wants to merge 1 commit into
Conversation
NastyBoget
self-requested a review
September 8, 2026 13:25
NastyBoget
reviewed
Sep 8, 2026
| else: | ||
| annotation = TableAnnotation(value=page_object.uid, start=0, end=len(best_line.line)) | ||
| elif isinstance(page_object, PdfImageAttachment): | ||
| annotation = AttachAnnotation(attach_uid=page_object.uid, start=0, end=len(best_line.line)) |
Collaborator
There was a problem hiding this comment.
См. комментарий #567 (comment)
аналогично нужно сделать для AttachAnnotation. А также для других ридеров, которые могут добавлять TableAnnotation или AttachAnnotation
NastyBoget
requested changes
Sep 8, 2026
Collaborator
|
Нужно исправить упавшие тесты. Проверка всех тестов: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TableAnnotationis now placed at the end of that line instead of the start.Closes #567
Test plan
python -m unittest tests.unit_tests.test_misc_line_object_linkerflake8 .