Enable Bengali localization and restore en.arb keys lost to a bad merge - #528
Open
arnavgoel17 wants to merge 1 commit into
Open
Enable Bengali localization and restore en.arb keys lost to a bad merge#528arnavgoel17 wants to merge 1 commit into
arnavgoel17 wants to merge 1 commit into
Conversation
…o a bad merge Bengali translation work was sitting unused: app_bn.arb existed but the locale was not selectable anywhere in the app. - Restore 98 keys silently dropped from app_en.arb by the conflict resolution in merge 79b5803 (welcomeToRhythma, all sms*, deleteAccount, insights*, nudge*, assistantAccessibility*, onboarding* keys). The generated Dart files had been hand-patched to keep compiling, which masked the loss until gen-l10n ran again. - Add the 10 missing Ayurveda keys to app_bn.arb and translate the 5 strings that were still English (insightsDisclaimer, logFlow*, logSymp*), so Bengali has full en.arb coverage. - Regenerate all localization Dart files via flutter gen-l10n. - Add bn (বাংলা) to appSupportedLanguages, which makes it selectable on both the onboarding language screen and Settings > Language, and lets LocaleProvider accept it. Tests: - flutter analyze: 0 issues (17 pre-existing errors on main). - flutter test: 118 passing, including a new test proving bn is accepted by LocaleProvider. Updated three tests that encoded pre-change behavior (8 vs 9 locales; stale l10n-based Hindi label; storage init that no longer compiles).
|
@arnavgoel17 is attempting to deploy a commit to the ishita2740's projects Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks
Owner
|
@arnavgoel17 I will merge the PR soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bengali translation work was sitting completely unused:
app_bn.arbexisted, but the generated Dart file was stale and — more importantly —bnwas excluded from every user-facing surface because enabling it would have crashed. This PR makes Bengali a real, selectable language.While validating with
flutter gen-l10n, a second, larger problem surfaced:98 keys had been silently dropped from
app_en.arbby the conflict resolution in merge 79b5803 ("Merge branch 'main' into feat/ayurvedic-educational-layer"). Everything fromwelcomeToRhythmaand all 17 phone+OTP login keys to the entiresms*,insightsNotEnoughData,deleteAccountandassistantAccessibility*families vanished from the source-of-truth ARB file while the generated Dart files kept them (hand-patched by bf2fbff to keep the app compiling). That hand-patching masked the loss — until anyone re-rangen-l10n, which is exactly what this issue asks for.What changed
app_en.arbverbatim from pre-merge commit d1346cb.insightsDisclaimer,logFlowVeryHeavy,logFlowSpotting,logSympSeverePain,logSympFainting).app_bn.arbnow covers every key inapp_en.arb.flutter gen-l10n.bn(বাংলা) toappSupportedLanguages— both the onboarding language screen and Settings → Language iterate this list, so one entry enables it in both places, andLocaleProvider.setLocalenow accepts it.setLocale(bn)is acceptedValidation
flutter gen-l10n: clean regeneration;app_bn.arbhas full key coverage ofapp_en.arb(verified programmatically)flutter analyze: 0 issues (baseline on main was 17 errors in committed generated files)flutter test: 118 passing, 0 failingFixes #297