[isaacsa51]

#316

Description

This change includes paid recurring transactions in analytics results.

Issue Linked (if any)

None provided.

Implemented

• Analytics spend, income, decrease, and chart-spend results now use the distinct union of one-time spends and paid recurring transactions.
• Added a test for past-due weekly recurring occurrences in current-period spend totals.
• The test expects 350.00 in both spends and chartSpends, including three Rent entries.

Working demo

No demo evidence provided.

Testing

• Ran :app:connectedFossDebugAndroidTest :app:verifyPaparazziFossDebug --continue for E2E test on a device and verify screenshots.
• Added/updated tests when applicable.
• Added screenshots or screen recordings for UI changes.

Test execution results were not provided.

Notes

No additional risks or follow-ups were provided.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0f9ebda5-fea2-4cb9-9663-bcd8fb1ee396

Commits

Reviewing files that changed from the base of the PR and between 474492c and 7659a3f.

Files selected for processing: 2

• app/src/main/java/com/serranoie/app/minus/presentation/ui/analytics/AnalyticsViewModel.kt
• app/src/test/java/com/serranoie/app/minus/presentation/ui/analytics/AnalyticsViewModelTest.kt

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The analytics view model now derives spend, income, decrease, and chart-spend results from distinct one-time spends and paid recurring transactions. A test checks totals for weekly recurring occurrences and a one-time transaction.

Changes: Analytics spend aggregation

Layer / File(s)	Summary
Build analytics results from actual transactions app/src/main/java/com/serranoie/app/minus/presentation/ui/analytics/AnalyticsViewModel.kt, app/src/test/java/com/serranoie/app/minus/presentation/ui/analytics/AnalyticsViewModelTest.kt	The view model filters spend, income, and decrease results from the distinct union of one-time spends and paid recurring transactions. Chart spends use the same list. The test checks three recurring Rent entries and totals of 350.00 in both spend collections.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

• Issue 316 reports that recurring expenses are omitted from analytics pie-chart tag sums. This change supplies chart spends from a list that includes paid recurring transactions.

Merge Risk: Minimal · up to 7659a

The analytics change is mergeable after normal checks; no actionable issue remains identified.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: including recurring payments in analytics.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}