Skip to content

Bump k8s.io/* deps to v0.36.3 and controller-runtime to v0.24.1 - #485

Open
Rohit-0505 wants to merge 2 commits into
ironcore-dev:mainfrom
opensovereigncloud:osc/chore/bump-k8s-1.36
Open

Bump k8s.io/* deps to v0.36.3 and controller-runtime to v0.24.1#485
Rohit-0505 wants to merge 2 commits into
ironcore-dev:mainfrom
opensovereigncloud:osc/chore/bump-k8s-1.36

Conversation

@Rohit-0505

@Rohit-0505 Rohit-0505 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Bump kubernetes deps to v0.36.3 and controller-runtime to v0.24.1

FIxes: #486

Summary by CodeRabbit

  • Chores
    • Updated supporting libraries and platform components, including Kubernetes, gRPC, telemetry, synchronization, system, and protocol packages.
    • Removed an unused supporting package.
    • Updated Kubernetes test assets to version 1.36.0.
    • Updated the code quality tooling to golangci-lint version 2.12.
    • No user-facing functionality changed.

@Rohit-0505
Rohit-0505 requested a review from a team as a code owner August 7, 2026 06:18
@github-actions github-actions Bot added the chore label Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@opensovereigncloud-user, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c427b7b-9201-45bb-8941-0ba6c472ddbc

📥 Commits

Reviewing files that changed from the base of the PR and between 9c48104 and 3d0f3f0.

📒 Files selected for processing (3)
  • Makefile
  • docs/api-reference/networking.md
  • hack/api-reference/config.json
📝 Walkthrough

Walkthrough

The PR updates direct and indirect Go dependencies in go.mod. It removes github.com/google/btree. It updates envtest Kubernetes assets and golangci-lint versions in the Makefile.

Changes

Go dependency and tooling updates

Layer / File(s) Summary
Dependency version updates
go.mod
Updates direct and indirect versions for Kubernetes, controller-runtime, gRPC, OpenTelemetry, synchronization, system, and generated protocol packages. Removes the indirect github.com/google/btree dependency.
Development tool version updates
Makefile
Updates envtest Kubernetes assets from 1.35.0 to 1.36.0 and golangci-lint from v2.11 to v2.12.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

  • ironcore-dev/ceph-provider#911 — Updates Kubernetes dependencies and envtest assets to the v0.36.x and 1.36.0 lines.
  • ironcore-dev/cloud-provider-ironcore#596 — Updates Kubernetes dependencies and assets to the v0.36 line.
  • ironcore-dev/machine-controller-manager-provider-ironcore#557 — Updates Kubernetes dependencies and envtest assets to the v0.36 and 1.36 lines.

Suggested reviewers: adracus

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The Makefile also upgrades golangci-lint from v2.11 to v2.12, which is unrelated to issue #486. Remove the unrelated golangci-lint version change or link it to a requirement covered by this pull request.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary Kubernetes and controller-runtime dependency upgrades.
Description check ✅ Passed The description states the dependency upgrade and references issue #486, but contains a minor capitalization typo in "FIxes."
Linked Issues check ✅ Passed The pull request upgrades the Kubernetes dependencies to v0.36.3, which satisfies issue #486.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Signed-off-by: Rohit Kumar <rohit.1si09ee045@gmail.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Line 6: Update the Makefile envtest configuration associated with
ENVTEST_K8S_VERSION to define ENVTEST_VERSION with a default of 0.24, replacing
the older 0.23 release so setup-envtest aligns with the Kubernetes v0.36.x
dependencies.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e6e9364d-18d1-43d9-8e75-b273f8bc4ed5

📥 Commits

Reviewing files that changed from the base of the PR and between ca34e20 and 9c48104.

📒 Files selected for processing (1)
  • Makefile

Comment thread Makefile
Signed-off-by: Rohit Kumar <rohit.1si09ee045@gmail.com>
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade k8s.io/* Dependencies to v0.36.x

1 participant