Skip to content

Introduces an optional flag to monitor the lifecycle of the dpservice - #466

Open
byteocean wants to merge 1 commit into
mainfrom
enh/pick-lockfile
Open

Introduces an optional flag to monitor the lifecycle of the dpservice#466
byteocean wants to merge 1 commit into
mainfrom
enh/pick-lockfile

Conversation

@byteocean

Copy link
Copy Markdown
Contributor

It is useful for enhancing robustness and can be used for the HA case.

inspired by osc commits: 7f2a1b0 + c2bcb3c, but this commit makes the --dpservice-lock flag optional.

… process.

It is useful for enhancing robustness and can be used for the HA case.

Signed-off-by: Tao Li <tao.li06@sap.com>
@github-actions github-actions Bot added enhancement New feature or request size/M labels Jul 10, 2026
@byteocean
byteocean requested a review from a team July 13, 2026 15:34
@PlagueCZ

PlagueCZ commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This has been abandoned in OSC by implementing health service in dpservice, this should not be implemented upstream.

Current OSC metalnet does not have this:
https://github.com/opensovereigncloud/metalnet/tree/osc/dpservice-ha-rebase

@PlagueCZ

Copy link
Copy Markdown
Contributor

Clarification - thi is the history of main.go:
https://github.com/opensovereigncloud/metalnet/commits/osc/dpservice-ha-rebase/main.go

unfortunately the commit message is misleading, but this is the commit that in the end removed dpservice-lock:

Refactor tests to use Ginkgo/Gomega and update dependencies
FlorinPeterbalpert89
FlorinPeter
authored and
balpert89
committed
on Nov 20, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants