Acls#3643
Open
DanPartelly wants to merge 50 commits into
Open
Conversation
Notable data structures: acl, acl_entry, acl_address.
Default to "permit" to ensure consistency with prefix list data model.
Hook into routing module
DanPartelly
marked this pull request as draft
July 16, 2026 16:12
jbemmel
reviewed
Jul 16, 2026
specified on interafces.
in transformed topology, breaking transformation tests. While at it, improved the function readability.
expansion from pool, prefix, and node/interface, node/role tuples
After testing multiple topologies, I came to the conclusion that specifying adress family for an ACL is best done with a string. The default has been set to "ipv4". This reverts commit 45e1baf.
prevented proper validation of port_range against operators
to validate acls/acl_addresses
optional, to reduce information on node and simplify template handling
While at it, set the flag to False for ios familiy
While at it, guard against routing.acl beeing undefined
jbemmel
reviewed
Jul 21, 2026
jbemmel
requested changes
Jul 21, 2026
jbemmel
left a comment
jbemmel
left a comment
Collaborator
There was a problem hiding this comment.
Indentation and whitespace should be made at least internally consistent and ideally in line with the rest of .j2 scripts
You may want to omit not_in support for now, and then add it whenever there is a need later. There is little point in calling out things that are not supported by any device.
- remove fallthrough in r_addr macro - indent jinja as per Netlab standards - consistent spacing - bug in ipv6 access list command generation - beautify interfaces section
This reverts commit 2428822.
after 242882 was reverted
form in data model. Add ipv6. While at it, update protocol_number table to reflect the changes
on busybox netcat. Since it doesn't proprely support -k option on server side, the tests are one shot.
source address.
jbemmel
reviewed
Jul 23, 2026
jbemmel
reviewed
Jul 23, 2026
jbemmel
reviewed
Jul 23, 2026
jbemmel
reviewed
Jul 23, 2026
jbemmel
reviewed
Jul 23, 2026
jbemmel
reviewed
Jul 23, 2026
jbemmel
reviewed
Jul 23, 2026
jbemmel
requested changes
Jul 23, 2026
jbemmel
left a comment
jbemmel
left a comment
Collaborator
There was a problem hiding this comment.
Few minor nits and optional alternatives
to please the eyes.
differences between IOS and IOS-XE
as string was changed without keeping the lookup table in sync.
DanPartelly
commented
Jul 23, 2026
| {% set log = " log" if e.log is defined else "" %} | ||
| {% set seq = "" if netlab_device_type in ['ios','iosvl2'] else e.sequence %} | ||
| {% if e.description is defined %} | ||
| {{seqcmd}}{{seq}} remark {{e.description}} |
Collaborator
Author
There was a problem hiding this comment.
This will fail on iosv, iosvl2 for af ipv6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACL implementation in progress. initial skeleton based on #3635