chore: bump deps and migrate to aws-sdk-go-v2#88
Merged
Conversation
Bumps 15 direct deps. Highlights: certmagic 0.21.6 to 0.25.3 (OCSP delegated-responder validation hardening), coredns 1.14.2 to 1.14.3 (built against Go 1.26.2, picking up stdlib CVE fixes), fsnotify 1.9.0 to 1.10.1 (inotify sibling-path watch removal, exercised by the denylist plugin), acmez/v3 3.0.0 to 3.1.6, pebble/v2 2.7.0 to 2.10.1 (test only), plus bart, go-datastore, multiaddr, multiaddr-dns, multibase, slok/go-http-metrics, aws-sdk-go, go-log, prometheus, zap. Pebble v2.10 forces TCP for ACME challenge DNS lookups and added two constructor params (keyAlg on ca.New, caaIdentities on wfe.New). The e2e_test harness now plumbs CoreDNS's TCP listener address alongside the UDP one through a new dnsServerAddresses helper that asserts the caddy ServerListener LocalAddr/Addr mapping, so a future swap to DoH/DoT/DoQ/gRPC fails loudly instead of feeding the wrong address. aws-sdk-go (v1) is end-of-support as of v1.55.8; flagged with a TODO in acme/setup.go for migration to aws-sdk-go-v2 once go-ds-dynamodb exposes a v2 constructor.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 69.11% 68.69% -0.42%
==========================================
Files 21 21
Lines 1703 1706 +3
==========================================
- Hits 1177 1172 -5
- Misses 407 415 +8
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lidel
commented
May 19, 2026
aws-sdk-go (v1) hit end-of-support in v1.55.8. The acme plugin's DynamoDB datastore now builds the client via dynamodb.NewFromConfig(config.LoadDefaultConfig(...)) and drops the v1 session import. Depends on ipfs/go-ds-dynamodb#22; pinned to that PR's head pending the v0.3.0 release.
lidel
force-pushed
the
chore/bump-direct-deps
branch
from
3673273 to
1121353
Compare
Cleanup was registered on c.OnFinalShutdown, which Caddy fires only on final process shutdown, not on a graceful reload. Each SIGUSR1 or reload-plugin restart spawned a fresh denylist Manager (HTTP feed tickers + fsnotify watcher) without releasing the previous instance's. Cleanup now runs on c.OnShutdown (per-stop), with mgr captured in the closure so the hook acts on this instance's manager regardless of sharedManager being overwritten by the successor instance's setup.
Copyedit pass on the Unreleased changelog entries, the dnsServerAddresses godoc in e2e_test.go, and the OnShutdown closure comment in denylist/plugin.go.
lidel
changed the title
Tracks ipfs/go-ds-dynamodb#22 at 5875687 (v0.3.0 changelog commit) while the PR is still open. Picks up scan/putKey/SetTTL fixes and batch-commit cancel-safety. No p2p-forge API changes; the aws-sdk-go-v2 migration already landed in 1121353.
Picks up typo fixes from @pranavkonde (#66, README) and @sujalsalekar (#67, client/acme.go godoc and inline comments). PR 66's docs/METRICS.md change no longer applies; that line was rewritten upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
aws-sdk-gov1 hit end-of-support in v1.55.8; the optional DynamoDB datastore was still on it.denylistleaked HTTP feed tickers and the fsnotify watcher on every Caddy reload. Cleanup ran onOnFinalShutdown, which fires only on final process exit, not on SIGUSR1 or thereloadplugin.certmagic,coredns, andfsnotifywere behind on, respectively, OCSP delegated-responder validation hardening, the Go 1.26.2 stdlib CVE sweep, and the inotify sibling-path watch-removal fix thatdenylistwas hitting.How this PR fixes it
go-ds-dynamodbto v0.3.0 (built onaws-sdk-go-v2); theacmeplugin builds the client viadynamodb.NewFromConfig(config.LoadDefaultConfig(...)), mirroring CoreDNS'sroute53plugin.denylistcleanup toOnShutdownwith theManagercaptured in the closure, so each per-stop release acts on the right instance.certmagicto v0.25.3,corednsto v1.14.3,fsnotifyto v1.10.1, and the rest of the direct deps; full list inCHANGELOG.md. Pebble v2.10 forces TCP for ACME DNS lookups, so the e2e harness now plumbs CoreDNS's TCP listener through adnsServerAddresseshelper.