Skip to content

check data masking #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjwadams merged 4 commits into from
Aug 26, 2026
+206 −86
Merged

check data masking #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c49025
check data masking
leilabbb Aug 19, 2026
9734266
replaced a function argument
leilabbb Aug 19, 2026
1a975d3
fixed log-report syntax and rewrote variable check function
leilabbb Aug 19, 2026
9741325
Change assertions from str to list in tests
leilabbb Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions glider_dac/tests/test_glider_qc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ def test_check_geophysical_variables_min_max(self):
temperature.valid_min = 10.0
temperature.valid_max = 5.0

result = qc.check_geophysical_variables("temperature")
result = qc.check_geophysical_variables(temperature)

assert isinstance(result, str)
assert "temperature has the valid_min and valid_max switched" in result
assert isinstance(result, list)
assert result == ['temperature has invalid valid_min/valid_max metadata in file; valid-range checks skipped']

def test_check_geophysical_variables_masked(self):
copypath = self.copy_ncfile(STATIC_FILES["murphy"])
Expand All @@ -77,10 +77,10 @@ def test_check_geophysical_variables_masked(self):
mask=np.ones(temperature.shape, dtype=bool),
)

result = qc.check_geophysical_variables("temperature")
result = qc.check_geophysical_variables(temperature)

assert isinstance(result, str)
assert "temperature is an array of masked values" in result
assert isinstance(result, list)
assert result == ['temperature has no valid data (fully masked/invalid)', 'temperature data breakdown: _FillValue=100.00%']

def test_check_geophysical_variables_nan(self):
copypath = self.copy_ncfile(STATIC_FILES["murphy"])
Expand All @@ -94,10 +94,10 @@ def test_check_geophysical_variables_nan(self):
# Set all values to NaN
temperature[:] = np.full(temperature.shape, np.nan, dtype=temperature.dtype)

result = qc.check_geophysical_variables("temperature")
result = qc.check_geophysical_variables(temperature)

assert isinstance(result, str)
assert "temperature is an array of NaNs" in result
assert isinstance(result, list)
assert result == ['temperature has no valid data (fully masked/invalid)', 'temperature data breakdown: NaN=100.00%']

def test_create_qc_variables(self):
copypath = self.copy_ncfile(STATIC_FILES["murphy"])
Expand Down
Loading