chore: remove downlevel-dts dependency - #174
Merged
Merged
Conversation
OS-pedrogustavobilro
requested review from
ItsChaceD,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
eric-horodyski,
jcesarmobile,
markemer and
theproducer
August 3, 2026 17:32
OS-pedrogustavobilro
marked this pull request as ready for review
August 4, 2026 13:29
Contributor
|
@OS-pedrogustavobilro Can you take a look at the conflict in pnpm-lock.yaml? It should be something pretty simple. |
Contributor
Author
|
@OS-ruimoreiramendes done |
OS-ruimoreiramendes
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin had
downlevel-dtsas a dev dependency, and it was bringingnextversion of typescript when runningpnpm install, which is now typescript 7; this was causing errors when runningpnpm run build; the plugin's on Typescript 5.It seems like
downlevel-dtswas added to fix an issue for TypeScript 3 (released in 2019), but Capacitor has been on Typescript 5 for some majors now. So I'd say it's safe to remove now, as this package is bringing more troubles than usefulness.This shouldn't really be a breaking change, but because it changes the outputs of
distfolder, and to keep it safe I'm pointing this PR tonextbranch.ℹ️ Note: The native Android build is failing but that is to be addressed in #173