Skip to content

Add eligibility group memberships to operator api#733

Open
tie-ioki wants to merge 4 commits into
mainfrom
add-eligibility-group-memberships-to-operator-api
Open

Add eligibility group memberships to operator api#733
tie-ioki wants to merge 4 commits into
mainfrom
add-eligibility-group-memberships-to-operator-api

Conversation

@tie-ioki

@tie-ioki tie-ioki commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

module Model
module Operator
class EligibilityGroupMembership < Base
attribute :email_address,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model is a bit convoluted. It combines the schema used in the POST request with the response serializer. We usually only do that if both are named identically and match conceptually (e.g. POST User schema returns a User). In this context, it seems the two models are conceptually different.

Personally I'd split them up:

  1. Ioki::Model::Operator::EligibilityGroupMembershipManuallyAssignByEmailAddress
  2. Ioki::Model::Operator::EligibilityGroupMembership

You should be able to set the schema as outgoing_model_class in the endpoint configuration.

@phylor phylor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants