Feature/corechanges logging by martinfalk · Pull Request #283 · inviwo/modules

martinfalk · 2026-05-08T11:43:12Z

No description provided.

…macro

…tring_view not a const string&

…a const string&

github-actions · 2026-06-16T08:08:44Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v19.1.7) reports: 8 concern(s)

medvis/dicom/src/datastructures/dicomdirtypes.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/dicom/datastructures/dicomdirtypes.h' file not found
```
   30 | #include <inviwo/dicom/datastructures/dicomdirtypes.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
medvis/dicom/src/errorlogging.cpp:31:10: error: [clang-diagnostic-error]

'inviwo/dicom/errorlogging.h' file not found
```
   31 | #include <inviwo/dicom/errorlogging.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
medvis/dicom/src/io/gdcmvolumereader.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/dicom/io/gdcmvolumereader.h' file not found
```
   30 | #include <inviwo/dicom/io/gdcmvolumereader.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

medvis/dicom/src/io/gdcmvolumereader.cpp:660:5: warning: [google-readability-todo]

missing username/bug in TODO

  660 |     // TODO: check this heuristic!!!
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     // TODO(runner): check this heuristic!!!

medvis/dicom/src/io/mevisvolumereader.cpp:52:10: error: [clang-diagnostic-error]

'inviwo/dicom/io/mevisvolumereader.h' file not found
```
   52 | #include <inviwo/dicom/io/mevisvolumereader.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

misc/graphviz/src/graphvizsettings.cpp:162:37: warning: [cppcoreguidelines-pro-type-const-cast]

do not use const_cast to remove const qualifier

  162 |             if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) {
      |                                     ^

misc/graphviz/src/graphvizsettings.cpp:178:33: warning: [cppcoreguidelines-pro-type-const-cast]

do not use const_cast to remove const qualifier

  178 |         if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) {
      |                                 ^

vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:95:50: warning: [readability-function-cognitive-complexity]

function 'initFunctions' has cognitive complexity of 32 (threshold 25)

   95 | void IntegralLinesToDataFrame::MetaDataSettings::initFunctions(
      |                                                  ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:98:5: note: +1, including nesting penalty of 0, nesting level increased to 1
   98 |     if (!isChecked()) {
      |     ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:109:5: note: +1, including nesting penalty of 0, nesting level increased to 1
  109 |     while (iss >> d) {
      |     ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:110:9: note: +2, including nesting penalty of 1, nesting level increased to 2
  110 |         if (d < 0) {
      |         ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:113:9: note: +2, including nesting penalty of 1, nesting level increased to 2
  113 |         if (d > 100) {
      |         ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:118:9: note: +2, including nesting penalty of 1, nesting level increased to 2
  118 |         if (d > 1) d /= 100;  // from percent to ratio
      |         ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:122:5: note: +1, including nesting penalty of 0, nesting level increased to 1
  122 |     if (!avg_.get() && !sd_.get() && percentiles.empty()) {
      |     ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:122:35: note: +1
  122 |     if (!avg_.get() && !sd_.get() && percentiles.empty()) {
      |                                   ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:126:5: note: +1, including nesting penalty of 0, nesting level increased to 1
  126 |     if (c == 1) {  // scalars
      |     ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:128:13: note: nesting level increased to 2
  128 |             [this, &funcs, df = &dataFrame, &percentiles, &name](auto ramT) {
      |             ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:131:35: note: nesting level increased to 3
  131 |                                   [](const T& v) -> float { return static_cast<float>(v); });
      |                                   ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:134:7: note: +1, nesting level increased to 1
  134 |     } else {  // vectors
      |       ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:135:63: note: nesting level increased to 2
  135 |         return ram->dispatch<void, dispatching::filter::Vecs>([this, &funcs, name, percentiles, c,
      |                                                               ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:138:13: note: +3, including nesting penalty of 2, nesting level increased to 3
  138 |             if (useMagnitude_.get()) {
      |             ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:139:66: note: nesting level increased to 4
  139 |                 createFunction<T>(funcs, *df, percentiles, name, [c](const T& v) -> float {
      |                                                                  ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:141:21: note: +5, including nesting penalty of 4, nesting level increased to 5
  141 |                     for (size_t i = 0; i < c; i++) {
      |                     ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:147:13: note: +3, including nesting penalty of 2, nesting level increased to 3
  147 |             if (x_.get()) {
      |             ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:150:21: note: nesting level increased to 4
  150 |                     [](const T& v) -> float { return static_cast<float>(util::glmcomp(v, 0)); });
      |                     ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:152:13: note: +3, including nesting penalty of 2, nesting level increased to 3
  152 |             if (y_.get()) {
      |             ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:155:21: note: nesting level increased to 4
  155 |                     [](const T& v) -> float { return static_cast<float>(util::glmcomp(v, 1)); });
      |                     ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:157:13: note: +3, including nesting penalty of 2, nesting level increased to 3
  157 |             if (z_.get()) {
      |             ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:160:21: note: nesting level increased to 4
  160 |                     [](const T& v) -> float { return static_cast<float>(util::glmcomp(v, 2)); });
      |                     ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:162:13: note: +3, including nesting penalty of 2, nesting level increased to 3
  162 |             if (w_.get()) {
      |             ^
/home/runner/work/modules/modules/inviwo/vectorvis/integrallinefiltering/src/processors/integrallinestodataframe.cpp:165:21: note: nesting level increased to 4
  165 |                     [](const T& v) -> float { return static_cast<float>(util::glmcomp(v, 3)); });
      |                     ^

Have any feedback or feature suggestions? Share it here.

outdated suggestion

bot

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.7

Click here for the full clang-tidy patch

diff --git a/medvis/dicom/src/io/gdcmvolumereader.cpp b/medvis/dicom/src/io/gdcmvolumereader.cpp
index 6610583..335fcb9 100644
--- a/medvis/dicom/src/io/gdcmvolumereader.cpp
+++ b/medvis/dicom/src/io/gdcmvolumereader.cpp
@@ -660 +660 @@ std::shared_ptr<Volume> GdcmVolumeReader::generateVolume(const gdcm::Image& imag
-    // TODO: check this heuristic!!!
+    // TODO(runner): check this heuristic!!!

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-06-23T10:35:38Z


-    // TODO: check this heuristics!!!
-    if (modality == "CT") {
+    // TODO: check this heuristic!!!


clang-tidy diagnostics

missing username/bug in TODO [google-readability-todo]

Suggested change

// TODO: check this heuristic!!!

// TODO(runner): check this heuristic!!!

github-actions · 2026-06-23T10:35:38Z

        net->forEachProcessor([&](Processor* p) {
-            if (auto* n = agnode(G, const_cast<char*>(p->getIdentifier().c_str()), 0)) {
+            const std::string identifier{p->getIdentifier()};
+            if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) {


clang-tidy diagnostic

misc/graphviz/src/graphvizsettings.cpp:162:37: warning: [cppcoreguidelines-pro-type-const-cast]

do not use const_cast to remove const qualifier

162 | if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) { | ^

github-actions · 2026-06-23T10:35:38Z

    net->forEachProcessor([&](Processor* p) {
-        if (auto* n = agnode(G, const_cast<char*>(p->getIdentifier().c_str()), 0)) {
+        const std::string identifier{p->getIdentifier()};
+        if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) {


clang-tidy diagnostic

misc/graphviz/src/graphvizsettings.cpp:178:33: warning: [cppcoreguidelines-pro-type-const-cast]

do not use const_cast to remove const qualifier

178 | if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) { | ^

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.7

Click here for the full clang-tidy patch

diff --git a/medvis/dicom/src/io/gdcmvolumereader.cpp b/medvis/dicom/src/io/gdcmvolumereader.cpp
index 6610583..335fcb9 100644
--- a/medvis/dicom/src/io/gdcmvolumereader.cpp
+++ b/medvis/dicom/src/io/gdcmvolumereader.cpp
@@ -660 +660 @@ std::shared_ptr<Volume> GdcmVolumeReader::generateVolume(const gdcm::Image& imag
-    // TODO: check this heuristic!!!
+    // TODO(runner): check this heuristic!!!

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-06-25T09:56:53Z


-    // TODO: check this heuristics!!!
-    if (modality == "CT") {
+    // TODO: check this heuristic!!!


clang-tidy diagnostics

missing username/bug in TODO [google-readability-todo]

Suggested change

// TODO: check this heuristic!!!

// TODO(runner): check this heuristic!!!

github-actions · 2026-06-25T09:56:53Z

        net->forEachProcessor([&](Processor* p) {
-            if (auto* n = agnode(G, const_cast<char*>(p->getIdentifier().c_str()), 0)) {
+            const std::string identifier{p->getIdentifier()};
+            if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) {


clang-tidy diagnostic

misc/graphviz/src/graphvizsettings.cpp:162:37: warning: [cppcoreguidelines-pro-type-const-cast]

do not use const_cast to remove const qualifier

162 | if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) { | ^

github-actions · 2026-06-25T09:56:53Z

    net->forEachProcessor([&](Processor* p) {
-        if (auto* n = agnode(G, const_cast<char*>(p->getIdentifier().c_str()), 0)) {
+        const std::string identifier{p->getIdentifier()};
+        if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) {


clang-tidy diagnostic

misc/graphviz/src/graphvizsettings.cpp:178:33: warning: [cppcoreguidelines-pro-type-const-cast]

do not use const_cast to remove const qualifier

178 | if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) { | ^

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.7

Click here for the full clang-tidy patch

diff --git a/medvis/dicom/src/io/gdcmvolumereader.cpp b/medvis/dicom/src/io/gdcmvolumereader.cpp
index 6610583..335fcb9 100644
--- a/medvis/dicom/src/io/gdcmvolumereader.cpp
+++ b/medvis/dicom/src/io/gdcmvolumereader.cpp
@@ -660 +660 @@ std::shared_ptr<Volume> GdcmVolumeReader::generateVolume(const gdcm::Image& imag
-    // TODO: check this heuristic!!!
+    // TODO(runner): check this heuristic!!!

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-06-29T10:08:48Z


-    // TODO: check this heuristics!!!
-    if (modality == "CT") {
+    // TODO: check this heuristic!!!


clang-tidy diagnostics

missing username/bug in TODO [google-readability-todo]

Suggested change

// TODO: check this heuristic!!!

// TODO(runner): check this heuristic!!!

github-actions · 2026-06-29T10:08:48Z

        net->forEachProcessor([&](Processor* p) {
-            if (auto* n = agnode(G, const_cast<char*>(p->getIdentifier().c_str()), 0)) {
+            const std::string identifier{p->getIdentifier()};
+            if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) {


clang-tidy diagnostic

misc/graphviz/src/graphvizsettings.cpp:162:37: warning: [cppcoreguidelines-pro-type-const-cast]

do not use const_cast to remove const qualifier

162 | if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) { | ^

github-actions · 2026-06-29T10:08:48Z

    net->forEachProcessor([&](Processor* p) {
-        if (auto* n = agnode(G, const_cast<char*>(p->getIdentifier().c_str()), 0)) {
+        const std::string identifier{p->getIdentifier()};
+        if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) {


clang-tidy diagnostic

misc/graphviz/src/graphvizsettings.cpp:178:33: warning: [cppcoreguidelines-pro-type-const-cast]

do not use const_cast to remove const qualifier

178 | if (auto* n = agnode(G, const_cast<char*>(identifier.c_str()), 0)) { | ^

bot

martinfalk added 2 commits May 8, 2026 13:38

C3D: warn fix

04c31aa

C3D: typo

4b3a8cc

martinfalk requested a review from petersteneteg May 8, 2026 11:43

martinfalk marked this pull request as ready for review May 8, 2026 11:43

petersteneteg approved these changes May 8, 2026

View reviewed changes

martinfalk force-pushed the feature/corechanges-logging branch 2 times, most recently from fc16939 to c90c79f Compare May 11, 2026 08:09

petersteneteg approved these changes May 11, 2026

View reviewed changes

martinfalk added 5 commits May 12, 2026 10:53

MedVis,VectorVis,Misc: remove IVW_CONTEXT_CUSTOM, remove old logging …

9115bd1

…macro

MedVis: enable DICOM module by default

85ba903

gha: add dicom

6161178

DICOM: linux fix

cd97046

ComputeShaderExamples: remove old logging macro

a86203c

martinfalk force-pushed the feature/corechanges-logging branch from c90c79f to a86203c Compare May 12, 2026 08:54

VTK,VectorVis,TensorVis: core changes - getIdentifier now returns a s…

a1958a0

…tring_view not a const string&

petersteneteg approved these changes May 12, 2026

View reviewed changes

GraphViz: core changes - getIdentifier now returns a string_view not …

11bb58e

…a const string&

petersteneteg approved these changes May 13, 2026

View reviewed changes

GHA: clang-tidy fix Add 'dicom' feature to VCPKG manifest

023c76f

github-actions Bot added the J: Regression Test Failure label Jun 16, 2026

This comment was marked as outdated.

Sign in to view

Testing: updated reference images

a193d9c

petersteneteg approved these changes Jun 17, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

github-actions Bot removed the J: Regression Test Failure label Jun 17, 2026

Misc: disable PythonTools module by default

2888a3e

This comment was marked as outdated.

Sign in to view

petersteneteg approved these changes Jun 23, 2026

View reviewed changes

github-actions Bot previously requested changes Jun 23, 2026

View reviewed changes

GHA: update ubuntu runners to 26-04

3101e2a

martinfalk force-pushed the feature/corechanges-logging branch from 8290430 to 3101e2a Compare June 25, 2026 07:46

github-actions Bot previously requested changes Jun 25, 2026

View reviewed changes

martinfalk added 3 commits June 29, 2026 09:58

GraphViz: warn fix

679743d

Dicom: out-of-bounds fix

b3d0802

GHA: disable dicom module *test*

2eac1ba

github-actions Bot previously requested changes Jun 29, 2026

View reviewed changes

petersteneteg merged commit f12e313 into master Jun 29, 2026
18 checks passed

petersteneteg deleted the feature/corechanges-logging branch June 29, 2026 15:24

github-actions Bot pushed a commit to inviwo/regression that referenced this pull request Jun 29, 2026

Remove regression reports for MERGED PR inviwo/modules#283

d0b3fc7

	// TODO: check this heuristic!!!
	// TODO(runner): check this heuristic!!!

Uh oh!

Conversation

martinfalk commented May 8, 2026

Uh oh!

github-actions Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.7

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Jun 23, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.7

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.7

Uh oh!

github-actions Bot Jun 29, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Jun 29, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

github-actions Bot Jun 29, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 16, 2026 •

edited

Loading