[PB-6513, PB-6515] Add login and pwd change with argon2 - #439
Open
TamaraFinogina wants to merge 5 commits into
Open
TamaraFinogina wants to merge 5 commits into
TamaraFinogina wants to merge 5 commits into
Conversation
sg-gs
reviewed
Aug 31, 2026
| token: Token; | ||
| user: UserSettings; | ||
| }>( | ||
| '/auth/login-argon2/access', |
Member
There was a problem hiding this comment.
Better to add a flag as a query param to the already existent EP than adding another one which does not follow REST.
Contributor
Author
There was a problem hiding this comment.
Done! Alternatively, I can put it inside params ("kdf: 'argon2'") to avoid query params
Contributor
Author
There was a problem hiding this comment.
btw, won't re-using the endpoint be harder? Because the server expects an encrypted hash and expects keys, so server actions would depend a lot on this flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoint for login and password change with Argon2, without sending keys and without encrypting with CRYPTO_SECRET
PB-6515
PB-6513