fix(db): validate SSL certificate on production database connections#67
Merged
Conversation
TamaraFinogina
approved these changes
Jul 10, 2026
Member
Author
|
It's still in draft @TamaraFinogina |
Contributor
|
Yes, but only due to the missing variable, no? |
|
Member
Author
|
Draft means not ready for review, with independence of the reason haha @TamaraFinogina. In fact, it was not just a value missing. I discovered migrations and server's db connection using independent sequelize configs. |
Member
Author
|
Now it's ready for review @TamaraFinogina. Tested it locally using OVH's certs. |
Member
Author
|
Environment variables are already configured in production also ✅ |
TamaraFinogina
approved these changes
Jul 10, 2026
jzunigax2
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Both database SSL configs now validate the server certificate (
rejectUnauthorized: true) instead of disabling verification:src/config/sequelize.js(used bysequelize-clifor migrations)src/app.module.ts(used by the running app, for both the main and drive database connections)The CA is read from environment variables (base64-encoded PEM), decoded via
ConfigServiceat runtime.Why
The previous config used
rejectUnauthorized: falsein both places, disabling certificate verification and exposing the connections to MITM attacks. The main and drive databases are separate instances, each with its own CA, so each connection now validates against its own certificate.DB_CA_CERT— base64-encoded PEM CA certificate for the main databaseDRIVE_DB_CA_CERT— base64-encoded PEM CA certificate for the drive database