adaptive: Treat SwOem conditions as unsupported instead of ODVP#582
Open
RevySR wants to merge 1 commit into
Open
adaptive: Treat SwOem conditions as unsupported instead of ODVP#582RevySR wants to merge 1 commit into
RevySR wants to merge 1 commit into
Conversation
Per Intel DPTF ConditionType.h, condition ids in [0x2000, 0x10000) are software-OEM conditions set at runtime by OEM software via DPTF/ESIF; they have no equivalent on Linux. thermald instead lumped the whole [0x1000, 0x10000) range into ODVP and mapped e.g. 0x200D to a non-existent odvp4115, logging "Unable to read odvp4115" every poll while verify_condition() still reported it as supported. Restrict the ODVP mapping to [0x1000, 0x2000) and treat [0x2000, 0x10000) as unsupported, taking the same quiet path as other unsupported conditions. No functional change - such sets were never satisfiable on Linux; this only drops the per-poll error spam. Signed-off-by: Han Gao <rabenda.cn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Intel DPTF ConditionType.h, condition ids in [0x2000, 0x10000) are software-OEM conditions set at runtime by OEM software via DPTF/ESIF; they have no equivalent on Linux. thermald instead lumped the whole [0x1000, 0x10000) range into ODVP and mapped e.g. 0x200D to a non-existent odvp4115, logging "Unable to read odvp4115" every poll while verify_condition() still reported it as supported.
Restrict the ODVP mapping to [0x1000, 0x2000) and treat [0x2000, 0x10000) as unsupported, taking the same quiet path as other unsupported conditions. No functional change - such sets were never satisfiable on Linux; this only drops the per-poll error spam.