callback: forward rvalue args - #950
Closed
benedekkupper wants to merge 1 commit into
Closed
Conversation
Preserve value category in callback::builder::run so services taking T&& receive rvalues instead of lvalues. Add a regression test for callback::service<MoveOnlyPayload&&>. Signed-off-by: Benedek Kupper <kupper.benedek@gmail.com>
Contributor
|
The reason it didn't do this before is that it's inside a fold expression. If there are multiple calllbacks you end up with a use-after-move. |
Author
This is a valid concern and one that I pondered too, but without a better alternative in mind I went with it anyway (just adding a comment at the callback type definition). For correctness though it should either allow rvalue forwarding, or explicitly forbid it by a |
Contributor
|
Thanks for the contribution! Based on the discussion here I fixed this problem in a slightly more robust way in #953. |
Author
|
I love the solution, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve value category in callback::builder::run so services taking T&& receive rvalues instead of lvalues.
Add a regression test for callback::service<MoveOnlyPayload&&>.