Fixes reactive errors with newer version of shiny

[averissimo]

Pull Request

• Part of Heads-up: shiny session cleanup will affect teal_slice tests (temporarily deferred for 1.14.0) teal.slice#682

[github-actions]

Unit Tests Summary

  1 files   27 suites   2m 3s ⏱️
263 tests 257 ✅ 6 💤 0 ❌
407 runs  401 ✅ 6 💤 0 ❌

Results for commit 5a6d46a.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
Reporter	💔	$91.69$	$+5.43$	$0$	$0$	$0$	$0$

Results for commit c963cad

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------------
R/add_card.R                    130      10  92.31%   47-54, 143, 184
R/download.R                    196      22  88.78%   27-33, 85-91, 153, 199-200, 265-269
R/editor_block.R                 28      15  46.43%   81-96
R/editor_card.R                  43      15  65.12%   2-15, 24
R/LoadReporterModule.R          110      32  70.91%   20-26, 105-110, 113-118, 124-129, 141-147
R/previewer_card_actions.R      119      17  85.71%   84-87, 98, 109-117, 121-122, 127
R/previewer_card.R               39      24  38.46%   2-27
R/previewer_content.R            52      23  55.77%   5-19, 28-29, 31-32, 47, 59, 63, 67
R/previewer_deprecated.R        143      54  62.24%   38-71, 113, 140-141, 160-161, 170-176, 198, 219-220, 240-249
R/previewer_report.R             80      26  67.50%   20-32, 94-108
R/render.R                       32       0  100.00%
R/ReportCard.R                   49       3  93.88%   51, 204, 225
R/Reporter.R                    165      19  88.48%   122, 165, 273-282, 318-319, 324-329, 398
R/ResetModule.R                  56       8  85.71%   20-27
R/SimpleReporter.R               30      15  50.00%   39-53
R/teal_card.R                   162       0  100.00%
R/teal_report-c.R                 5       0  100.00%
R/teal_report-class.R            26       2  92.31%   50, 131
R/teal_report-eval_code.R         6       0  100.00%
R/teal_report-extract.R           3       0  100.00%
R/to_rmd.R                       92      25  72.83%   15, 117-125, 127, 142, 164-172, 259-277
R/toHTML.R                       53       7  86.79%   128-134, 170, 245-279
R/utils.R                        96      28  70.83%   25, 34, 127-152
R/yaml_utils.R                   81       0  100.00%
R/zzz.R                          30       1  96.67%   30
TOTAL                          1826     346  81.05%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 5a6d46a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[llrs-roche]

I tried to test this branch with the examples on teal.osprey and I still see

Error: Can't access reactive reactiveVal85f53c6a; its module session has been destroyed

I used:

1. load_all("teal.reporter")
2. load_all("teal.osprey")
3. run_examples("teal.osprey")
4. Change a picks input and you'll see the errors.

Maybe I'm testing something different that needs to be fixed on teal.picks.
Other than that the changes look ok (just a minor comment about the NEWS).

[averissimo]

which version of teal.slice do you have installed?

[averissimo]

@llrs-roche can you try the 682_fix_shiny_round_2 branch on teal.slice and see if you can still reproduce the error.

[llrs-roche]

With the new branch on teal.slice (682_fix_shiny_round_2) I could run the examples on teal.osprey without any error message about reactiveVal()