Fix false Valid results from constructor proof fields - #223
Open
RSoulatIOHK wants to merge 2 commits into
Open
Conversation
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructor equality can report a false theorem as
Validwhen structures have proof fields. For example,ProofBox.mk 7 (Or.inl True.intro) ≠ ProofBox.mk 7 (Or.inr True.intro)reduced toTrue, although Lean proves the equality byrfl.Treat proof fields as equal before comparing constructor tags, and consume a successful structural comparison so values differing only in proofs simplify to equality. Ordinary data fields still distinguish constructors. The same issue is covered inside lists.
Validation:
Validresult on betabafdd4f7.rflwitness, five optimizer regressions, and two negative solver regressions requiringFalsified.lake build Blaster Tests.FixedIssues.Issue225passed.lake build Tests.Optimizepassed (449 build jobs).This PR targets
beta-lambda-cache-optimizationand is the first soundness fix from the branch review.Fixes #225. Regression:
Tests/FixedIssues/Issue225.lean.