[FIX] product_replenishment_cost: correct misleading update wizard message - #918
Closed
les-adhoc wants to merge 1 commit into
Closed
[FIX] product_replenishment_cost: correct misleading update wizard message#918les-adhoc wants to merge 1 commit into
les-adhoc wants to merge 1 commit into
Conversation
Contributor
les-adhoc
force-pushed
the
19.0-h-123474-les
branch
3 times, most recently
from
July 22, 2026 14:09
0c8e27d to
424fb5d
Compare
Contributor
|
@roboadhoc r+ nobump |
Contributor
|
@jcadhoc you may want to rebuild or fix this PR as it has failed CI. |
Contributor
|
@roboadhoc rebuild |
Contributor
|
@mav-adhoc unknown command 'rebuild'. For your own safety I've ignored everything in your entire comment. Currently available commands:
Note: this help text is dynamic and will change with the state of the PR. |
Contributor
|
@roboadhoc retry |
Contributor
|
@mav-adhoc retry makes no sense when the PR is not in error. |
les-adhoc
force-pushed
the
19.0-h-123474-les
branch
3 times, most recently
from
July 27, 2026 20:03
72485e6 to
aaa6d35
Compare
…ssage The "Update Accounting Cost from Replenishment Cost" wizard stated the action only applied to products with the "Standard Price" costing method. However, _update_cost_from_replenishment_cost() overwrites standard_price for products of any costing method (it only filters replenishment_cost != 0), as reproduced on an AVCO category where the cost went from 0 to a non-zero value on confirm. The action itself is intentional (e.g. currency-based valuation), so only the message is corrected: it no longer restricts the scope to the "Standard Price" costing method. Source terms re-exported (.pot).
les-adhoc
force-pushed
the
19.0-h-123474-les
branch
from
July 28, 2026 12:41
aaa6d35 to
26f2b36
Compare
Contributor
|
@roboadhoc r+ nobump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The "Update Accounting Cost from Replenishment Cost" wizard message stated the action only applied to products with the "Standard Price" costing method:
However,
_update_cost_from_replenishment_cost()inproduct_template.pyoverwritesstandard_pricefor products of any costing method — it only filtersreplenishment_cost != 0and never checks the category costing method. This was reproduced on an AVCO category, where the cost went from0to a non-zero value on confirm.Change
The action itself is intentional (useful e.g. for currency-based valuation), so the behavior is not blocked. Only the wizard message is corrected so it no longer restricts the scope to the
"Standard Price"costing method:Source terms re-exported (
.pot). Translations are handled by the usual Transifex sync.Test plan
Ref: https://www.adhoc.inc/odoo/action-helpdesk.helpdesk_ticket_action_main/123474