[IMP] academic: next year groups dedup and user feedback - #439
Open
lef-adhoc wants to merge 1 commit into
Open
Conversation
Contributor
|
|
lef-adhoc
force-pushed
the
19.0-t-70712-lef
branch
4 times, most recently
from
August 7, 2026 19:49
69fe46e to
eb458fe
Compare
create_next_year_groups now matches the group unique constraint when searching for existing next year groups (section_id and subject_id were missing, so a subject group could silently reuse the commercial group) and returns a notification with created/existing counters chained to the next year groups list. Extract _get_next_year_group and _get_or_create_next_year_group for reuse by the re-enrollment flow. Task: 70712
lef-adhoc
force-pushed
the
19.0-t-70712-lef
branch
from
August 7, 2026 19:49
eb458fe to
101ce4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_next_year_groups now matches the group unique constraint when searching for existing next year groups (section_id and subject_id were missing, so a subject group could silently reuse the commercial group) and returns a notification with created/existing counters chained to the next year groups list. Extract _get_next_year_group and _get_or_create_next_year_group for reuse by the re-enrollment flow.
Task: 70712