[REM] academic: move "grant access to all" button to portal_ux - #431
[REM] academic: move "grant access to all" button to portal_ux#431gal-adhoc wants to merge 1 commit into
Conversation
|
|
The generic "Grant Access to All" button on the portal wizard was academic-specific but had no academic logic in it. It now lives in the horizontal module portal_ux, available on any database. academic depends on portal_ux to keep the button; the partner_type-based group assignment override on portal.wizard.user is untouched and keeps applying through polymorphism.
81fec0a to
8936156
Compare
|
Nota sobre CI: No hay nada que arreglar en el código de este PR por este motivo — es un tema de orden de merge. Sugerencia: mergear #418 primero, después este PR debería pasar CI limpio. |
|
@roboadhoc override=ci/runbot-smarted |
|
@roboadhoc r+ |
|
@gal-adhoc @nicomacr this PR cannot be staged without a bump policy. Please specify either |
|
@roboadhoc nobump |
Adds a "Grant Access to All" button to the portal access wizard (portal.wizard) that grants portal access to every contact listed in the wizard with a valid email in a single action, instead of having to click "Grant Access" row by row. closes #418 Related: ingadhoc/odoo-academic#431 Signed-off-by: Franco Leyes <lef@adhoc.com.ar>
3 participants
Summary
Follow-up to ingadhoc/miscellaneous#418, which generalizes the "Grant Access to All" button on the portal wizard (
portal.wizard) into a new horizontal moduleportal_ux. That button had no academic-specific logic, so it's removed from here and provided byportal_uxinstead.academic/wizards/portal_wizard.py: removedaction_grant_access_all()(moved toportal_ux, unchanged). Kept the academic-specific_default_portal()/portal_id.academic/wizards/portal_wizard_views.xml: removed (its only content was the button, now added byportal_ux).__manifest__.py: addedportal_uxtodepends, removed the now-deleted view fromdata.academic/wizards/portal_wizard_user.py. Its override ofaction_grant_access()(assigns portal groups bypartner_type) is vertical logic and keeps applying by polymorphism — the generic button inportal_uxiteratesuser_idsand callsaction_grant_access(), which on a database withacademicinstalled still runs the academic override. Behavior for existing academic users is unchanged.Branch shares the same name as ingadhoc/miscellaneous#418 so both build together on runbot.
Test plan
academic+portal_uxtogether → only one "Grant Access to All" button shows on the wizard (no duplicate).partner_typeare still assigned correctly.academicmodule updates cleanly after the view removal.