[FIX] academic_payment_portal: filter invoices by payment responsible - #413
Open
cav-adhoc wants to merge 1 commit into
Open
[FIX] academic_payment_portal: filter invoices by payment responsible#413cav-adhoc wants to merge 1 commit into
cav-adhoc wants to merge 1 commit into
Conversation
Contributor
|
|
When a payment responsible user logs into the portal, they should only see invoices for students where they are listed as payment responsible. Previously, users could see all invoices for their students regardless of who was responsible for payment. This caused: - Access errors (403 Forbidden) when trying to pay invoices - Incorrect total amounts displayed - Confusion when multiple payment responsibles exist (e.g., mother/father) Solution: Override _get_selected_invoices_domain() to filter invoices by student_id.payment_responsible_ids, ensuring users only see invoices they are responsible for paying. The fix only applies when account_payment_multi is installed (try/except) to maintain optional dependency and avoid breaking installations without the multi-payment module.
cav-adhoc
force-pushed
the
17.0-h-116689-cav
branch
from
May 29, 2026 12:06
7fa99e9 to
25428bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a payment responsible user logs into the portal, they should only see invoices for students where they are listed as payment responsible.
Previously, users could see all invoices for their students regardless of who was responsible for payment. This caused:
Solution:
Override _get_selected_invoices_domain() to filter invoices by student_id.payment_responsible_ids, ensuring users only see invoices they are responsible for paying.
The fix only applies when account_payment_multi is installed (try/except) to maintain optional dependency and avoid breaking installations without the multi-payment module.