update .gitignore to exclude nats; add nats script#3
Open
matoszz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Anderson <42154938+matoszz@users.noreply.github.com>
matoszz
force-pushed
the
add-missing-nats-scripts
branch
from
d24f4cc to
df6b381
Compare
sfunkhouser
reviewed
Jul 13, 2023
| @@ -0,0 +1,15 @@ | |||
| // Operator "LOCAL" | |||
Contributor
There was a problem hiding this comment.
You shouldn't need this, its generated by the nats_init.sh script you have added
sfunkhouser
reviewed
Jul 13, 2023
|
|
||
| export ACCOUNTS_SIGNING_KEY_ID=`nsc describe account LOC -J | jq -r '.nats.signing_keys | first'` | ||
|
|
||
| echo "Creating NATS user for location-api" |
Contributor
There was a problem hiding this comment.
Suggested change
| echo "Creating NATS user for location-api" | |
| echo "Creating NATS user for example-api" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside of this repository and docker compose there are references to NATs scripts which do not exist and fail to initialize when attempting to use the devcontainer or compose. This PR adds the missing scripts as well as updates the .gitignore to exclude the generated NATs configuration