Fix incorrect return type annotations in base_api#153
Open
johanzander wants to merge 2 commits into
Open
Conversation
The method returns a dict (with 'data' and 'totalData' keys) from the API's "back" field, not a list. The annotation incorrectly stated list[dict[str, Any]]. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The method returns a list of devices (confirmed by TLX examples iterating
over the result), not a dict. Fix annotation to list[dict[str, Any]] and
default from {} to [].
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plant_listreturn type fromlist[dict[str, Any]]todict[str, Any]— it returns a dict withdataandtotalDatakeys__get_all_devicesreturn type fromdict[str, Any]tolist[dict[str, Any]]and default from{}to[]— it returns a list of devicesContext
Confirmed by existing examples:
noah_example.pyaccessesplant_list["data"]andplant_list["totalData"](dict, not list)tlx_example.pyiteratesfor device in devices:directly overdevice_list()result (list, not dict)Test plan
🤖 Generated with Claude Code