Conversation
space-wizards#4035 wants to use `KillSignComponent.DoOffset` so the sword sprite appears above the mob, but due to the rigidness of the offset calculation, it doesn't properly offset above and is slightly clipping Urist in tests. BREAKING CHANGE: `KillSignComponent.DoOffset` has been obsoleted for Offset. For sprites of height 32 using `DoOffset`, the equivalent `Offset` value is 16.1875f.
github-actions
Bot
added
S: Untriaged
S: Needs Review
size/S
Changes: Upstream
and removed
S: Needs Review
S: Untriaged
size/S
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
KillSignComponent.DoOffsetwas checked in its system for applying a fixed vertical offset based on the height of the sprite. Now it's deprecated in favor of withKillSignComponent.Offset, which can be set to any float to accommodate novel offsets.Why / Balance
#4035 wants to use
KillSignComponent.DoOffsetso the sword sprite appears above the mob, but due to the rigidness of the offset calculation, it doesn't properly offset above and is slightly clipping Urist in tests.Also
DoOffsetis used like nowhere so it's safe to change this to be less annoyingTechnical details
BREAKING CHANGE:
KillSignComponent.DoOffsethas been obsoleted for Offset. For sprites of height 32 usingDoOffset, the equivalentOffsetvalue is 16.1875f.Media
N/A
Requirements
Licensing
Changelog