Conversation
github-actions
Bot
added
S: Needs Review
size/XS
S: Untriaged
Changes: No C#
Changes: Port
and removed
S: Untriaged
labels
|
fwiw you wouldnt be able to relicense this change to mit because its modifying ported agpl code |
Author
I thought the checkbox was just for my changes to the code in this PR only, not the original too? Could you clarify cause thats what I'm getting from the text |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
The parent got updated upstream to use triggers causing it to become a normal figurine if opened inside a container
Why / Balance
Technical details
Could have updated the spaceblades to use SpawnEntityTableOnTrigger but didn't want to, Frontier hasn't fixed it yet anyways
Media
Requirements
Licensing
Changelog