Fix: donor name recording conflict with Charitable plugin - #8292
Open
WayneRocha wants to merge 2 commits into
Open
Fix: donor name recording conflict with Charitable plugin#8292WayneRocha wants to merge 2 commits into
WayneRocha wants to merge 2 commits into
Conversation
WayneRocha
marked this pull request as ready for review
August 20, 2026 07:17
Contributor
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SMTNC-1448
Have Charitable install and active.
Simply make a new donation logged-out (to create a new donor)
In the current version name will not be recorded.
In the fixed it will.
Description
When both GiveWP and Charitable are active, donor first and last names were not recorded for new donors.
Charitable registers a
plugins_loadedhook that reassigns the global$wpdb->donormetato its owncharitable_donormetatable. GiveWP's donor meta operations go through WordPress'sadd_metadata('donor', …)/get_metadata('donor', …), which resolve the table via_get_meta_table()using that same global. As a result, the first/last name meta was written to Charitable's table instead ofgive_donormeta, leaving GiveWP's Donor list names blank.This change makes
Give_DB_Metatemporarily re-assert$wpdb->{meta_type}metato GiveWP's own table around each metadata operation, then restore the previous value so other plugins (like Charitable) are unaffected.Affects
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocksNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.