fix: make react-select loading and no-options strings translatable - #8266
Open
faisalahammad wants to merge 1 commit into
Open
fix: make react-select loading and no-options strings translatable#8266faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
The async Campaign filter dropdowns on the Donations and Donors admin list tables rendered react-select's hardcoded English defaults (Loading... and No options) because the shared AsyncFilter wrapper did not pass loadingMessage and noOptionsMessage. Pass both through __() from @wordpress/i18n so they follow the active site language. Fixes impress-org#8165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The async Campaign filter dropdowns on the Donations (Select Campaign) and Donors (All Campaigns) admin list tables rendered react-select's hardcoded English defaults (
Loading...andNo options) because the sharedAsyncFilterwrapper did not passloadingMessageandnoOptionsMessage. Both props are now passed through__()from@wordpress/i18nso they follow the active site language.Fixes #8165
Changes
src/Views/Components/ListTable/CustomFilter/index.tsx
Before:
After:
Why: The Campaign dropdown on both list tables renders through this single
AsyncFiltercomponent (via thecampaignselectfilter type). Adding the two props here covers both pages with one change and matches the pattern already used insrc/Admin/fields/AsyncSelectOption/index.tsx.Testing
Test 1: Donations list, non-English locale
en_USlocale (e.g. Dutchnl_NL).Result: both strings follow the active site language instead of English.
Test 2: Donors list, non-English locale
Result: loading and empty strings are translated, no hardcoded English.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.