Move package.nix to example (vibe-kanban) - #31
Merged
Conversation
All tasks for **move-packages-nix-to-example** have been completed: ### Changes Made **In `shelffiles/` directory:** | File | Change | |------|--------| | `example/packages.nix` | Created new template file with example packages | | `flake.nix` | Updated to check for root `packages.nix` first, fallback to `example/packages.nix` | | `.gitignore` | Added `/packages.nix` to prevent tracking user customizations | | `README.md` | Updated instructions to copy example to root before customizing | | `packages.nix` | Removed from git tracking (file still exists for existing users) | ### Validation Results - `nix build --dry-run` works with only `example/packages.nix` present - `nix build --dry-run` works with root `packages.nix` present (uses it in preference) - All Docker-based tests pass (3/3 tests ok) ### Next Steps The changes are ready to be staged and committed. Would you like me to commit these changes?
- `.gitignore` no longer includes `/packages.nix` - The local `packages.nix` file is untracked (as expected - it's a user file) - Users can track their own `packages.nix` in their forks without conflicts
- `example/packages.nix` is just a template for copy/paste - `flake.nix` simply imports `./packages.nix` (no fallback logic) - Users must copy the example before building
- `packages.nix` is deleted from git (moved to `example/packages.nix`) - `example/packages.nix` has example comments for users to copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/openspec:proposal
Move package.nix to examples directory to avoid conflict with user change.
Instead, we should add instruction in README