Isolate Install() collector failures in Audience SDK#818
Closed
nattb8 wants to merge 1 commit into
Closed
Conversation
…sable the other CollectGameLaunchProperties() and CollectContext() ran unguarded back to back in Install(), so an exception in either (e.g. a Screen.currentResolution read too early in boot) left both providers unassigned for the rest of the session, silently stripping context and game_launch device data from every event. Each collector is now isolated in its own try/catch, with the failure logged and the provider still assigned (with whatever partial data survives).
Audience SDK — Build Size
SDK Size = build minus empty app. Change = vs baseline. Fails if any platform exceeds its absolute size limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CollectGameLaunchProperties()andCollectContext()ran back to back with no error handling inAudienceUnityHooks.Install(). An exception in either (most likely aScreen.currentResolutionread too early in boot) abortedInstall()before the other collector's provider was assigned, silently disabling it too. Each collector now runs in its own try/catch, with the failure logged viaLog.Warnand its provider still assigned using whatever partial data survives.Why
Field data showed real integrators hitting exactly this: one early-boot exception silently stripped context (locale/screen/timezone/userAgent) and
game_launchdevice fields from every event for practically the whole session, with no crash or visible error to flag it.Test plan
CollectContext()to throw, confirmed the uncaught exception silently blanked context andgame_launchproperties for the rest of the session (verified via raw event payloads)locale/timezone/userAgentstill came through with onlyscreenmissinggame_launch's own properties (version,cpu,gpu,unity_version, etc.) were unaffected by the context-collector failure, verifying the two collectors are isolated from each other