fix(audience): backdate session_end timestamp to when the session actually ended#815
Merged
Merged
Conversation
nattb8
force-pushed
the
feat/sdk-645-backdate-session-end-timestamp
branch
4 times, most recently
from
168b017 to
e004e49
Compare
nattb8
changed the title
…ually ended session_end can only be detected once something else happens (the app wakes up, or gets shut down), never at the actual moment the session stopped. Backdate the wire eventTimestamp to _pausedAt whenever the session ends while backgrounded, across every path that can end a session (Resume rollover, Dispose, Shutdown), so it reflects when backgrounding began instead of detection time. Matches duration_sec's existing engagement-aware behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
nattb8
force-pushed
the
feat/sdk-645-backdate-session-end-timestamp
branch
from
e004e49 to
a7a5f4f
Compare
Audience SDK — Build Size
SDK Size = build minus empty app. Change = vs baseline. Fails if any platform exceeds its absolute size limit. |
JCSanPedro
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SDK-645.
What
session_endnow backdates its wireeventTimestampto the moment the app actually stopped being active, instead of the moment the SDK happened to notice.Why
session_endcan only be detected once something else happens (the app wakes up, or gets shut down) — never at the actual moment the session stopped. Previously the event was always timestamped at that detection moment, so a session that ended by backgrounding could show asession_endtimestamped minutes or hours later than reality.Scenarios this fixes
session_endtimestamped at reopen (e.g. 1hr later)session_endtimestamped at quitsession_endtimestamped at quitCaveat:
duration_secon the same event remains the only field with zero pause skew — it excludes every pause in a session, short and long. The backdated timestamp only corrects for the final pause before the session ends, so a session with an earlier short (<=30s) alt-tab will still show a small residual gap (bounded by that pause's length) betweensession_end.timestamp - session_start.timestampandduration_sec. For exact engaged-time math, useduration_sec.Test plan
dotnet testonAudience.Tests.csproj— full suite greenMessageBuilder.Trackhonors an explicit timestamp override and normalizes non-UTC input, and a characterization test locking in the short-pause caveat